Differential D23343

Replace obsolete qSort(), QSignalMapper, and child() with non-obsolete methods
ClosedPublic
Actions

Authored by yurchor on Aug 22 2019, 11:14 AM.

Tags

None

Subscribers

aacid, Localization

Details

Reviewers

sdepiets
aacid

Commits

R456:10711dc8bd9c: Replace obsolete qSort(), QSignalMapper, and child() with non-obsolete methods

Test Plan

Compile and install.
Run Lokalize, try to insert proposals from TM, try to remove TM entries.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

yurchor requested review of this revision.Aug 22 2019, 11:14 AM

yurchor created this revision.

Harbormaster completed remote builds in B15460: Diff 64292.Aug 22 2019, 11:14 AM

aacid added a subscriber: aacid.Aug 22 2019, 5:07 PM

aacid added inline comments.

src/project/projectwidget.cpp
398	is idx.model() just "model" here? i think it'd make more sense to use that here and below, could you check if that's the case?

Use just model instead of idx.model(). Tested to work well with my projects. Thanks.

Harbormaster completed remote builds in B15491: Diff 64335.Aug 22 2019, 5:26 PM

aacid accepted this revision.Aug 22 2019, 8:25 PM

This revision is now accepted and ready to land.Aug 22 2019, 8:25 PM

Closed by commit R456:10711dc8bd9c: Replace obsolete qSort(), QSignalMapper, and child() with non-obsolete methods (authored by yurchor). · Explain WhyAug 23 2019, 5:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/alttransview.cpp (6 lines)
M			src/catalog/catalogstring.cpp (4 lines)
M			src/catalog/phase.cpp (2 lines)
M			src/catalog/xliff/xliffstorage.cpp (2 lines)
M			src/glossary/glossary.cpp (2 lines)
M			src/glossary/glossarywindow.cpp (2 lines)
M			src/mergemode/mergecatalog.cpp (4 lines)
M			src/msgctxtview.cpp (2 lines)
M			src/project/projectmodel.cpp (2 lines)
M			src/project/projectwidget.cpp (4 lines)
M			src/tm/jobs.cpp (4 lines)
M			src/tm/tmview.cpp (13 lines)
M			src/webquery/webqueryview.cpp (6 lines)

Diff 64387

src/alttransview.cpp

Loading...

src/catalog/catalogstring.cpp

Loading...

src/catalog/phase.cpp

Loading...

src/catalog/xliff/xliffstorage.cpp

Loading...

src/glossary/glossary.cpp

Loading...

src/glossary/glossarywindow.cpp

Loading...

src/mergemode/mergecatalog.cpp

Loading...

src/msgctxtview.cpp

Loading...

src/project/projectmodel.cpp

Loading...

src/project/projectwidget.cpp

Loading...

src/tm/jobs.cpp

Loading...

src/tm/tmview.cpp

Loading...

src/webquery/webqueryview.cpp

Loading...