Differential D22721 Diff 62596 addons/backtracebrowser/CMakeLists.txt

Changeset View

Standalone View

View Options

addons/backtracebrowser/CMakeLists.txt

1########### next target ############### ​
2add_definitions(-DTRANSLATION_DOMAIN=\"katebacktracebrowserplugin\") ​
3 ​
4include_directories( ${CMAKE_CURRENT_BINARY_DIR} ) ​
5 ​
6set(katebacktracebrowserplugin_PART_SRCS 1​set(katebacktracebrowserplugin_PART_SRCS
7 katebacktracebrowser.cpp 2​ katebacktracebrowser.cpp
8 btparser.cpp 3​ btparser.cpp
9 btfileindexer.cpp 4​ btfileindexer.cpp
10 btdatabase.cpp 5​ btdatabase.cpp
11) 6​)
12 7​
13set(katebacktracebrowserplugin_PART_UI 8​set(katebacktracebrowserplugin_PART_UI
14 btbrowserwidget.ui 9​ btbrowserwidget.ui
15 btconfigwidget.ui 10​ btconfigwidget.ui
16) 11​)
12​
17ki18n_wrap_ui(katebacktracebrowserplugin_PART_SRCS ${katebacktracebrowserplugin_PART_UI} ) 13​ki18n_wrap_ui(katebacktracebrowserplugin_PART_SRCS ${katebacktracebrowserplugin_PART_UI})
18add_library(katebacktracebrowserplugin MODULE ${katebacktracebrowserplugin_PART_SRCS}) ​
19 14​
20# we compile in the .desktop file 15​add_library(katebacktracebrowserplugin MODULE ${katebacktracebrowserplugin_PART_SRCS})
21kcoreaddons_desktop_to_json (katebacktracebrowserplugin katebacktracebrowserplugin.desktop) 16​target_compile_definitions(katebacktracebrowserplugin PRIVATE TRANSLATION_DOMAIN="katebacktracebrowserplugin")
turbovUnsubmitted
Done

Raw string literals probably could help to avoid awkward escapes:

target_compile_definitions(
    katebacktracebrowserplugin PRIVATE 
    [[TRANSLATION_DOMAIN="katebacktracebrowserplugin"]]
)

need to test...

turbov: Raw string literals probably could help to avoid awkward escapes…
daandemeyerAuthorUnsubmitted
Done

I'm actually not sure if the escapes are necessary anymore when using target_compile_definitions. I'll do some tests.

daandemeyer: I'm actually not sure if the escapes are necessary anymore when using…
22 17​
23target_link_libraries(katebacktracebrowserplugin 18​target_link_libraries(
19​ katebacktracebrowserplugin
20​ PRIVATE
24 KF5::TextEditor 21​ KF5::TextEditor
25 KF5::I18n 22​ KF5::I18n
turbovUnsubmitted
Done

IMHO this formatting style is much clean:

target_link_libraries(
  katebacktracebrowserplugin 
  PRIVATE
    KF5::TextEditor
    KF5::I18n
)
  • add the indentation after named keywords with multiple arguments
  • leave the open parentheses alone
turbov: IMHO this formatting style is much clean: ``` target_link_libraries…
daandemeyerAuthorUnsubmitted
Done

Agreed, I'll update to this style.

daandemeyer: Agreed, I'll update to this style.
26) 23​)
27 24​
28########### install files ############### 25​kcoreaddons_desktop_to_json(katebacktracebrowserplugin katebacktracebrowserplugin.desktop)
29install( TARGETS katebacktracebrowserplugin DESTINATION ${PLUGIN_INSTALL_DIR}/ktexteditor ) 26​install(TARGETS katebacktracebrowserplugin DESTINATION ${PLUGIN_INSTALL_DIR}/ktexteditor)
30 27​
31############# unit tests ################ ​
32if (BUILD_TESTING) 28​if(BUILD_TESTING)
33 add_subdirectory(autotests) 29​ add_subdirectory(autotests)
34endif() 30​endif()