Differential D21783 Diff 59738 src/core/jobuidelegateextension.h

Changeset View

Standalone View

src/core/jobuidelegateextension.h

Show First 20 Lines • Show All 261 Lines • ▼ Show 20 Line(s)		147	public:
262	* Creates a clipboard updater as a child of the given job.	262		* Creates a clipboard updater as a child of the given job.
263	*/	263		*/
264	virtual ClipboardUpdater createClipboardUpdater(Job job, ClipboardUpdaterMode mode);	264		virtual ClipboardUpdater createClipboardUpdater(Job job, ClipboardUpdaterMode mode);
265	/**	265		/**
266	* Update URL in clipboard, if present	266		* Update URL in clipboard, if present
267	*/	267		*/
268	virtual void updateUrlInClipboard(const QUrl &src, const QUrl &dest);	268		virtual void updateUrlInClipboard(const QUrl &src, const QUrl &dest);
269		269
		270		/**
		271		* Asks for confirmation to start a privileged file operation.
		272		*
		273		* @param warningCaption the caption of the warning dialog.
		274		* @param warningMessage the message shown in the warning dialog.
		275		* @param warningDetails the details of the current privileged operation.
		276		*
		277		* @since 5.60
		278		*/
		279		virtual bool askPrivilegeOperationConfirmation(const QString &warningCaption,
			dfaureUnsubmitted Not Done Sorry, you can't add a new virtual method to an exported+installed class. BIC rules (where "rules" is a noun, not a verb...) ;-) Possible solutions: creating a new, separate, type of extension, say `JobUiDelegatePrivilegeExtension`. This requires adding another defautFoo() and setFoo() method like this file has at the bottom. creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, with a KF6 TODO to merge it with JobUiDelegateExtension. Then you can dynamic_cast the result of `defaultJobUiDelegateExtension()` to V2 to see if the extension implements V2. dfaure: Sorry, you can't add a new virtual method to an exported+installed class. BIC rules (where…
			chinmoyrAuthorUnsubmitted Not Done Sorry, you can't add a new virtual method to an exported+installed class. BIC rules (where "rules" is a noun, not a verb...) ;-) LOL! Either way it's true. Possible solutions: creating a new, separate, type of extension, say JobUiDelegatePrivilegeExtension. This requires adding another defautFoo() and setFoo() >method like this file has at the bottom. creating a "JobUiDelegateExtensionV2", derived from JobUiDelegateExtension, with a KF6 TODO to merge it with JobUiDelegateExtension. >Then you can dynamic_cast the result of defaultJobUiDelegateExtension() to V2 to see if the extension implements V2. IMO trying to pass job details from SlaveBase to KMessageBox without breaking compatibility would result in an unnecessarily large patch. So I went ahead with reusing sslMetaData which was hacky but the resulting patch wasn't an eye-sore. I hope we can keep this and later add proper API in KF6. chinmoyr: >Sorry, you can't add a new virtual method to an exported+installed class. > >BIC rules (where…
		280		const QString &warningMessage,
		281		const QString &warningDetails) = 0;
270	private:	282		private:
271	class Private;	283		class Private;
272	Private *const d;	284		Private *const d;
273	};	285		};
274		286
275	/**	287		/**
276	* Returns the default job UI delegate extension to be used by all KIO jobs (in which HideProgressInfo is not set)	288		* Returns the default job UI delegate extension to be used by all KIO jobs (in which HideProgressInfo is not set)
277	* Can return NULL, if no kio GUI library is loaded.	289		* Can return NULL, if no kio GUI library is loaded.
Show All 17 Lines