Changeset View
Changeset View
Standalone View
Standalone View
autotests/CMakeLists.txt
Show First 20 Lines • Show All 252 Lines • ▼ Show 20 Line(s) | 246 | target_link_libraries(testScreens | |||
---|---|---|---|---|---|
253 | KF5::ConfigGui | 253 | KF5::ConfigGui | ||
254 | KF5::I18n | 254 | KF5::I18n | ||
255 | KF5::Notifications | 255 | KF5::Notifications | ||
256 | KF5::WindowSystem | 256 | KF5::WindowSystem | ||
257 | ) | 257 | ) | ||
258 | 258 | | |||
259 | add_test(NAME kwin_testScreens COMMAND testScreens) | 259 | add_test(NAME kwin_testScreens COMMAND testScreens) | ||
260 | ecm_mark_as_test(testScreens) | 260 | ecm_mark_as_test(testScreens) | ||
261 | 261 | | |||
262 | ######################################################## | 262 | ######################################################## | ||
zzag: No, I think we should keep the test. How about turning TestXRandRScreens into an integration… | |||||
After thinking for a while, I think there is no any value behind this test, so we could drop it. I still think that we need some tests to verify that KWin works correctly when an output gets added or removed, but this is completely unrelated to what this patch intends to achieve. zzag: After thinking for a while, I think there is no any value behind this test, so we could drop it. | |||||
263 | # Test XrandRScreens | | |||
264 | ######################################################## | | |||
265 | set( testXRandRScreens_SRCS | | |||
266 | test_xrandr_screens.cpp | | |||
267 | mock_abstract_client.cpp | | |||
268 | mock_client.cpp | | |||
269 | mock_screens.cpp | | |||
270 | mock_workspace.cpp | | |||
271 | ../screens.cpp | | |||
272 | ../plugins/platforms/x11/standalone/screens_xrandr.cpp | | |||
273 | ../xcbutils.cpp # init of extensions | | |||
274 | ../x11eventfilter.cpp | | |||
275 | ../orientation_sensor.cpp | | |||
276 | ) | | |||
277 | kconfig_add_kcfg_files(testXRandRScreens_SRCS ../settings.kcfgc) | | |||
278 | qt5_add_dbus_adaptor( testXRandRScreens_SRCS ${CMAKE_CURRENT_SOURCE_DIR}/../org.kde.kwin.OrientationSensor.xml ${CMAKE_CURRENT_SOURCE_DIR}/../orientation_sensor.h KWin::OrientationSensor) | | |||
279 | add_executable( testXRandRScreens ${testXRandRScreens_SRCS} ) | | |||
280 | target_link_libraries( testXRandRScreens | | |||
281 | Qt5::Test | | |||
282 | Qt5::DBus | | |||
283 | Qt5::Gui | | |||
284 | Qt5::Sensors | | |||
285 | Qt5::Widgets | | |||
286 | KF5::ConfigCore | | |||
287 | KF5::ConfigGui | | |||
288 | KF5::I18n | | |||
289 | KF5::Notifications | | |||
290 | KF5::WindowSystem | | |||
291 | XCB::XCB | | |||
292 | XCB::RANDR | | |||
293 | XCB::XFIXES | | |||
294 | XCB::SYNC | | |||
295 | XCB::COMPOSITE | | |||
296 | XCB::DAMAGE | | |||
297 | XCB::GLX | | |||
298 | XCB::SHM | | |||
299 | ) | | |||
300 | | ||||
301 | add_test(NAME kwin-testXRandRScreens COMMAND testXRandRScreens) | | |||
302 | ecm_mark_as_test(testXRandRScreens) | | |||
303 | | ||||
304 | ######################################################## | | |||
305 | # Test ScreenEdges | 263 | # Test ScreenEdges | ||
306 | ######################################################## | 264 | ######################################################## | ||
307 | set( testScreenEdges_SRCS | 265 | set( testScreenEdges_SRCS | ||
308 | test_screen_edges.cpp | 266 | test_screen_edges.cpp | ||
309 | mock_abstract_client.cpp | 267 | mock_abstract_client.cpp | ||
310 | mock_client.cpp | 268 | mock_client.cpp | ||
311 | mock_screens.cpp | 269 | mock_screens.cpp | ||
312 | mock_workspace.cpp | 270 | mock_workspace.cpp | ||
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines |
No, I think we should keep the test. How about turning TestXRandRScreens into an integration test instead?