Changeset View
Changeset View
Standalone View
Standalone View
kerfuffle/plugin.cpp
Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Line(s) | 62 | { | |||
---|---|---|---|---|---|
64 | return isDeclaredReadWrite && findExecutables(readWriteExecutables()); | 64 | return isDeclaredReadWrite && findExecutables(readWriteExecutables()); | ||
65 | } | 65 | } | ||
66 | 66 | | |||
67 | QStringList Plugin::readOnlyExecutables() const | 67 | QStringList Plugin::readOnlyExecutables() const | ||
68 | { | 68 | { | ||
69 | QStringList readOnlyExecutables; | 69 | QStringList readOnlyExecutables; | ||
70 | 70 | | |||
71 | const QJsonArray array = m_metaData.rawData()[QStringLiteral("X-KDE-Kerfuffle-ReadOnlyExecutables")].toArray(); | 71 | const QJsonArray array = m_metaData.rawData()[QStringLiteral("X-KDE-Kerfuffle-ReadOnlyExecutables")].toArray(); | ||
72 | foreach (const QJsonValue &value, array) { | 72 | for (const QJsonValue &value : array) { | ||
73 | readOnlyExecutables << value.toString(); | 73 | readOnlyExecutables << value.toString(); | ||
74 | } | 74 | } | ||
75 | 75 | | |||
76 | return readOnlyExecutables; | 76 | return readOnlyExecutables; | ||
77 | } | 77 | } | ||
78 | 78 | | |||
79 | QStringList Plugin::readWriteExecutables() const | 79 | QStringList Plugin::readWriteExecutables() const | ||
80 | { | 80 | { | ||
81 | QStringList readWriteExecutables; | 81 | QStringList readWriteExecutables; | ||
82 | 82 | | |||
83 | const QJsonArray array = m_metaData.rawData()[QStringLiteral("X-KDE-Kerfuffle-ReadWriteExecutables")].toArray(); | 83 | const QJsonArray array = m_metaData.rawData()[QStringLiteral("X-KDE-Kerfuffle-ReadWriteExecutables")].toArray(); | ||
84 | foreach (const QJsonValue &value, array) { | 84 | for (const QJsonValue &value : array) { | ||
85 | readWriteExecutables << value.toString(); | 85 | readWriteExecutables << value.toString(); | ||
86 | } | 86 | } | ||
87 | 87 | | |||
88 | return readWriteExecutables; | 88 | return readWriteExecutables; | ||
89 | } | 89 | } | ||
90 | 90 | | |||
91 | KPluginMetaData Plugin::metaData() const | 91 | KPluginMetaData Plugin::metaData() const | ||
92 | { | 92 | { | ||
93 | return m_metaData; | 93 | return m_metaData; | ||
94 | } | 94 | } | ||
95 | 95 | | |||
96 | bool Plugin::hasRequiredExecutables() const | 96 | bool Plugin::hasRequiredExecutables() const | ||
97 | { | 97 | { | ||
98 | return findExecutables(readOnlyExecutables()); | 98 | return findExecutables(readOnlyExecutables()); | ||
99 | } | 99 | } | ||
100 | 100 | | |||
101 | bool Plugin::isValid() const | 101 | bool Plugin::isValid() const | ||
102 | { | 102 | { | ||
103 | return isEnabled() && m_metaData.isValid() && hasRequiredExecutables(); | 103 | return isEnabled() && m_metaData.isValid() && hasRequiredExecutables(); | ||
104 | } | 104 | } | ||
105 | 105 | | |||
106 | bool Plugin::findExecutables(const QStringList &executables) | 106 | bool Plugin::findExecutables(const QStringList &executables) | ||
107 | { | 107 | { | ||
108 | foreach (const QString &executable, executables) { | 108 | for (const QString &executable : executables) { | ||
109 | if (executable.isEmpty()) { | 109 | if (executable.isEmpty()) { | ||
110 | continue; | 110 | continue; | ||
111 | } | 111 | } | ||
112 | 112 | | |||
113 | if (QStandardPaths::findExecutable(executable).isEmpty()) { | 113 | if (QStandardPaths::findExecutable(executable).isEmpty()) { | ||
114 | return false; | 114 | return false; | ||
115 | } | 115 | } | ||
116 | } | 116 | } | ||
117 | 117 | | |||
118 | return true; | 118 | return true; | ||
119 | } | 119 | } | ||
120 | 120 | | |||
121 | } | 121 | } |