CMakeLists.txt
89	Is 5.56 the first KF5 release that builds without foreach? If yes, can you add a comment explaining the reason for this check?
autotests/kerfuffle/deletetest.cpp
59–60	Please call this variable `formats`
autotests/kerfuffle/extracttest.cpp
485–486	Please call this variable `formats`
autotests/testhelper/abstractaddtest.cpp
51–52	Please call this variable `formats`
kerfuffle/archiveentry.cpp
178–179	Please call this variable `archiveEntries`
kerfuffle/cliproperties.cpp
78–79	Please call this variable `commentSwitches`
kerfuffle/pluginmanager.cpp
127–130	Please call this variable `plugins`

This revision now requires changes to proceed.Jun 1 2019, 9:33 AM

mlaurent added inline comments.Jun 1 2019, 12:14 PM

CMakeLists.txt
89	Before it we can't build it without foreach as kconfig had some header with some Q_FOREACH

Fix comments reported on phabricator

Harbormaster completed remote builds in B12314: Diff 58979.Jun 1 2019, 12:24 PM

Thanks

This revision is now accepted and ready to land.Jun 1 2019, 1:29 PM

Closed by commit R36:4047949609f1: Make it compile without foreach (authored by mlaurent). · Explain WhyJun 1 2019, 7:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (5 lines)
M			app/batchextract.cpp (2 lines)
M			app/extractHereDndPlugin.cpp (2 lines)
M			app/extractfileitemaction.cpp (3 lines)
M			app/mainwindow.cpp (6 lines)
M			autotests/kerfuffle/addtest.cpp (4 lines)
M			autotests/kerfuffle/addtoarchivetest.cpp (2 lines)
M			autotests/kerfuffle/copytest.cpp (8 lines)
M			autotests/kerfuffle/deletetest.cpp (5 lines)
M			autotests/kerfuffle/extracttest.cpp (5 lines)
M			autotests/kerfuffle/jobstest.cpp (10 lines)
M			autotests/kerfuffle/jsonarchiveinterface.cpp (4 lines)
M			autotests/kerfuffle/jsonparser.cpp (3 lines)
M			autotests/kerfuffle/metadatatest.cpp (2 lines)
M			autotests/kerfuffle/movetest.cpp (8 lines)
M			autotests/plugins/cli7zplugin/cli7ztest.cpp (5 lines)
M			autotests/plugins/clirarplugin/clirartest.cpp (5 lines)
M			autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp (5 lines)
M			autotests/plugins/clizipplugin/cliziptest.cpp (5 lines)
M			autotests/testhelper/abstractaddtest.cpp (5 lines)
M			kerfuffle/addtoarchive.cpp (2 lines)
M			kerfuffle/archive_kerfuffle.cpp (2 lines)
M			kerfuffle/archiveentry.cpp (5 lines)
M			kerfuffle/archiveformat.cpp (7 lines)
M			kerfuffle/archiveinterface.cpp (8 lines)
M			kerfuffle/cliinterface.cpp (28 lines)
M			kerfuffle/cliproperties.cpp (15 lines)
M			kerfuffle/createdialog.cpp (2 lines)
M			kerfuffle/jobs.cpp (4 lines)
M			kerfuffle/plugin.cpp (6 lines)
M			kerfuffle/pluginmanager.cpp (33 lines)
M			kerfuffle/pluginsettingspage.cpp (3 lines)
M			part/archivemodel.cpp (16 lines)
M			part/infopanel.cpp (2 lines)
M			part/jobtracker.cpp (2 lines)
M			part/overwritedialog.cpp (2 lines)
M			part/part.cpp (22 lines)
M			plugins/cli7zplugin/cliplugin.cpp (2 lines)
M			plugins/cliunarchiverplugin/cliplugin.cpp (2 lines)
M			plugins/libarchive/libarchiveplugin.cpp (2 lines)
M			plugins/libarchive/readwritelibarchiveplugin.cpp (2 lines)
M			plugins/libsinglefileplugin/singlefileplugin.cpp (2 lines)
M			plugins/libzipplugin/libzipplugin.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58967	6687447		May 31 2019, 7:10 PM	★	★
Diff 2	58979	6687447	Fix comments reported on phabricator	Jun 1 2019, 12:24 PM	★	★
Diff 3	58991	42c8e2d	R36:4047949609f11daf7c1aea0b3f1b0914587fd5c2	Jun 1 2019, 7:08 PM	★	★