Changeset View
Changeset View
Standalone View
Standalone View
CMakeLists.txt
Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Line(s) | 80 | if (WITH_TEST_COVERAGE) | |||
---|---|---|---|---|---|
81 | set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage") | 81 | set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage") | ||
82 | set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage") | 82 | set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage") | ||
83 | set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --coverage") | 83 | set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --coverage") | ||
84 | endif (WITH_TEST_COVERAGE) | 84 | endif (WITH_TEST_COVERAGE) | ||
85 | 85 | | |||
86 | set(SUPPORTED_ARK_MIMETYPES "") | 86 | set(SUPPORTED_ARK_MIMETYPES "") | ||
87 | 87 | | |||
88 | add_definitions(-DTRANSLATION_DOMAIN="ark") | 88 | add_definitions(-DTRANSLATION_DOMAIN="ark") | ||
89 | # Until kf5 5.56 kconfig had some header which used Q_FOREACH | ||||
elvisangelaccio: Is 5.56 the first KF5 release that builds without foreach?
If yes, can you add a comment… | |||||
Before it we can't build it without foreach as kconfig had some header with some Q_FOREACH mlaurent: Before it we can't build it without foreach as kconfig had some header with some Q_FOREACH | |||||
90 | # Q_FOREACH will be deprecated/removed in qt6. With QT_NO_FOREACH we prepare the migration to qt6. | ||||
91 | if (${KF5Config_VERSION} STRGREATER "5.56.0") | ||||
92 | add_definitions(-DQT_NO_FOREACH) | ||||
93 | endif() | ||||
89 | 94 | | |||
90 | add_subdirectory(plugins) | 95 | add_subdirectory(plugins) | ||
91 | add_subdirectory(kerfuffle) | 96 | add_subdirectory(kerfuffle) | ||
92 | add_subdirectory(part) | 97 | add_subdirectory(part) | ||
93 | add_subdirectory(app) | 98 | add_subdirectory(app) | ||
94 | add_subdirectory(doc) | 99 | add_subdirectory(doc) | ||
95 | 100 | | |||
96 | if(BUILD_TESTING) | 101 | if(BUILD_TESTING) | ||
Show All 9 Lines |
Is 5.56 the first KF5 release that builds without foreach?
If yes, can you add a comment explaining the reason for this check?