Changeset View
Standalone View
conf/dlgannotationsbase.ui
| Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Line(s) | 33 | <layout class="QGridLayout" > | |||
|---|---|---|---|---|---|
| 47 | <number>6</number> | 47 | <number>6</number> | ||
| 48 | </property> | 48 | </property> | ||
| 49 | <property name="verticalSpacing" > | 49 | <property name="verticalSpacing" > | ||
| 50 | <number>6</number> | 50 | <number>6</number> | ||
| 51 | </property> | 51 | </property> | ||
| 52 | <item row="0" column="0" > | 52 | <item row="0" column="0" > | ||
| 53 | <widget class="QLabel" name="label" > | 53 | <widget class="QLabel" name="label" > | ||
| 54 | <property name="text" > | 54 | <property name="text" > | ||
| 55 | <string>&Author:</string> | 55 | <string>Author:</string> | ||
ngraham: Is this change intentional? If so, can we just move the ampersand around so that it still has… | |||||
Yes. Both Author and Add had 'a' as accelerator. This was actually working. Pressing 'a' twice switch between the two. Nonetheless I changed it to make the accelerators unique. Initially I set 'u' as accelerator for Author but this was conflicting with 'Move Up' and the accelerator of author was automatically changed to 't' once running Okular. (not sure why this did not happen also for 'a'). Then I noticed that not setting the accelerator let Qt set one automatically, so I decided to not set it. Mainly because I though that it make sense to set it only if it has a logical sense like 'u' for Move Up or 'd' for Move Down, but given that 't' is a random letter of author I decided to let it be automatic. Maybe it is better to set one explicitly? simgunz: Yes.
Both Author and Add had 'a' as accelerator. This was actually working. Pressing 'a' twice… | |||||
It's not Qt. It's kxmlgui that does the autoaccelerator magic. In principle it's always better to set it manually, this way translators know there's an accelrator and can try to set one that makes sense themselves and not leave it to "randomness" of the autoaccelerator magic. aacid: It's not Qt. It's kxmlgui that does the autoaccelerator magic. In principle it's always better… | |||||
| 56 | </property> | 56 | </property> | ||
| 57 | <property name="alignment" > | 57 | <property name="alignment" > | ||
| 58 | <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> | 58 | <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> | ||
| 59 | </property> | 59 | </property> | ||
| 60 | <property name="buddy" > | 60 | <property name="buddy" > | ||
| 61 | <cstring>kcfg_IdentityAuthor</cstring> | 61 | <cstring>kcfg_IdentityAuthor</cstring> | ||
| 62 | </property> | 62 | </property> | ||
| 63 | </widget> | 63 | </widget> | ||
| 64 | </item> | 64 | </item> | ||
| 65 | <item row="0" column="1" > | 65 | <item row="0" column="1" > | ||
| 66 | <widget class="QLineEdit" name="kcfg_IdentityAuthor" /> | 66 | <widget class="QLineEdit" name="kcfg_IdentityAuthor" /> | ||
| 67 | </item> | 67 | </item> | ||
| 68 | <item row="1" column="0" colspan="2" > | 68 | <item row="1" column="0" colspan="2" > | ||
| 69 | <widget class="QLabel" name="label_2" > | 69 | <widget class="QLabel" name="label_2" > | ||
| 70 | <property name="text" > | 70 | <property name="text" > | ||
| 71 | <string><b>Note</b>: the information here is used only for comments and reviews. Information inserted here will not be transmitted without your knowledge.</string> | 71 | <string><b>Note</b>: the information here is used only for comments and reviews. Information inserted here will not be transmitted without your knowledge.</string> | ||
I think this could be: Reason: When annotating a document without having the side panel open, then saving and distributing the document, the user might not know that this information is transmitted, because her/his name was never displayed. davidhurka: I think this could be:
**Note:** The information here is used only for annotations.
Information… | |||||
I have not understood the reason. This message is only displayed in the configuration dialog. In any case we could change it for me. simgunz: I have not understood the reason. This message is only displayed in the configuration dialog. | |||||
I suggested two sentences to change.
Currently, the message is indicating in two ways, that the information is not transmitted when the user fills forms using Typewriter and sends the document to someone else. Is this now explained better? davidhurka: >>! In D10859#472832, @simgunz wrote:
> What should we do regarding the message at line 71 of… | |||||
| 72 | </property> | 72 | </property> | ||
| 73 | <property name="alignment" > | 73 | <property name="alignment" > | ||
| 74 | <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set> | 74 | <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignTop</set> | ||
| 75 | </property> | 75 | </property> | ||
| 76 | <property name="wordWrap" > | 76 | <property name="wordWrap" > | ||
| 77 | <bool>true</bool> | 77 | <bool>true</bool> | ||
| 78 | </property> | 78 | </property> | ||
| 79 | </widget> | 79 | </widget> | ||
| Show All 30 Lines | |||||
Is this change intentional? If so, can we just move the ampersand around so that it still has an accelerator?