Differential D19329 Diff 52603 lib/marble/geodata/data/GeoDataCoordinates.h

Changeset View

Standalone View

View Options

lib/marble/geodata/data/GeoDataCoordinates.h

Context not available.
373 */ 373​ */
374 QString toString() const; 374​ QString toString() const;
375 375​
376​ /**
377​ * @brief enum used to specify the order of latitude and longitude when converted to string
378​ */
379​ enum LatLonOrder {
380​ OrderLonLat,
381​ OrderLatLon
382​ };
383​
376 /** 384​ /**
377 * @brief return a string with the notation given by notation 385​ * @brief return a string with the notation given by notation
378 * 386​ *
Context not available.
384 * In DMS a precision of 1 or 2 shows the arc minutes; a precision 392​ * In DMS a precision of 1 or 2 shows the arc minutes; a precision
rahnUnsubmitted
Not Done

such booleans as parameters always look dull (https://ariya.io/2011/08/hall-of-api-shame-boolean-trap). What about using an enum instead ?

rahn: such booleans as parameters always look dull (https://ariya.io/2011/08/hall-of-api-shame…
385 * of 3 or 4 will show arc seconds. A precision beyond that will 393​ * of 3 or 4 will show arc seconds. A precision beyond that will
386 * increase the number of digits after the arc second decimal point. 394​ * increase the number of digits after the arc second decimal point.
395​ * @param order if OrderLatLon, coordinate order is latitude before
396​ * longitude, as specified in ISO 6709. Default is OrderLonLat to be
397​ * consistent with the previous behaviour. This parameter is ignored
398​ * for UTM notation
387 */ 399​ */
388 QString toString( GeoDataCoordinates::Notation notation, int precision = -1 ) const; 400​ QString toString( GeoDataCoordinates::Notation notation, int precision = -1,
389 401​ GeoDataCoordinates::LatLonOrder order = OrderLonLat ) const;
402​
390 static QString lonToString( qreal lon, GeoDataCoordinates::Notation notation, 403​ static QString lonToString( qreal lon, GeoDataCoordinates::Notation notation,
391 GeoDataCoordinates::Unit unit = Radian, 404​ GeoDataCoordinates::Unit unit = Radian,
392 int precision = -1, 405​ int precision = -1,
Context not available.