Differential D18452 Diff 52252 autotests/integration/buffer_size_change_test.cpp

Changeset View

Standalone View

View Options

autotests/integration/buffer_size_change_test.cpp

  • This file was added.
1​/********************************************************************
2​KWin - the KDE window manager
3​This file is part of the KDE project.
4​
5​Copyright 2019 Roman Gilg <subdiff@gmail.com>
6​
zzagUnsubmitted
Not Done

Nitpick: missing "(C)". :D

zzag: Nitpick: missing "(C)". :D
7​This program is free software; you can redistribute it and/or modify
8​it under the terms of the GNU General Public License as published by
9​the Free Software Foundation; either version 2 of the License, or
10​(at your option) any later version.
11​
12​This program is distributed in the hope that it will be useful,
13​but WITHOUT ANY WARRANTY; without even the implied warranty of
14​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​GNU General Public License for more details.
16​
17​You should have received a copy of the GNU General Public License
18​along with this program. If not, see <http://www.gnu.org/licenses/>.
19​*********************************************************************/
20​#include "generic_scene_opengl_test.h"
21​
22​#include "composite.h"
23​#include "shell_client.h"
24​#include "wayland_server.h"
zzagUnsubmitted
Done

Includes should be sorted.

zzag: Includes should be sorted.
25​
26​#include <KWayland/Client/xdgshell.h>
27​#include <KWayland/Client/subsurface.h>
28​#include <KWayland/Client/surface.h>
29​
30​namespace KWin
31​{
32​
33​static const QString s_socketName = QStringLiteral("wayland_test_buffer_size_change-0");
34​
35​class BufferSizeChangeTest : public GenericSceneOpenGLTest
36​{
37​ Q_OBJECT
38​public:
39​ BufferSizeChangeTest() : GenericSceneOpenGLTest(QByteArrayLiteral("O2")) {}
40​private Q_SLOTS:
41​ void init();
42​ void testShmBufferSizeChange();
43​ void testShmBufferSizeChangeOnSubSurface();
44​};
45​
46​void BufferSizeChangeTest::init()
47​{
48​ QVERIFY(Test::setupWaylandConnection());
49​}
50​
51​void BufferSizeChangeTest::testShmBufferSizeChange()
52​{
zzagUnsubmitted
Done

Missing "this test verifies ..."

zzag: Missing "this test verifies ..."
53​ // This test verifies that an SHM buffer size change is handled correctly
54​
55​ using namespace KWayland::Client;
56​
zzagUnsubmitted
Done

Just QVERIFY(surface);

zzag: Just QVERIFY(surface);
zzagUnsubmitted
Done

Please ignore this one.

zzag: Please ignore this one.
57​ QScopedPointer<Surface> surface(Test::createSurface());
58​ QVERIFY(!surface.isNull());
zzagUnsubmitted
Done

Why ShellSurface?

zzag: Why ShellSurface?
59​
60​ QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
zzagUnsubmitted
Done

Could you please add an explanatory comment for this flush?

zzag: Could you please add an explanatory comment for this flush?
zzagUnsubmitted
Done

Also, do we need it anyway (flush)?

zzag: Also, do we need it anyway (flush)?
61​ QVERIFY(!shellSurface.isNull());
62​ Test::flushWaylandConnection();
63​
zzagUnsubmitted
Done

We usually do QVERIFY after renderAndWaitForShown. :-)

zzag: We usually do QVERIFY after renderAndWaitForShown. :-)
64​ // set buffer size
65​ ShellClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
66​ QVERIFY(client);
67​
68​ // add a first repaint
69​ QSignalSpy swapSpy(Compositor::self(), &Compositor::bufferSwapCompleted);
70​ QVERIFY(swapSpy.isValid());
71​ Compositor::self()->addRepaintFull();
72​ QVERIFY(swapSpy.wait());
73​
74​ // now change buffer size
75​ Test::render(surface.data(), QSize(30, 10), Qt::red);
76​ Test::flushWaylandConnection();
77​
78​ QSignalSpy damagedSpy(client, &ShellClient::damaged);
79​ QVERIFY(damagedSpy.isValid());
80​ QVERIFY(damagedSpy.wait());
zzagUnsubmitted
Not Done

Also, it would be great to destroy the client, though that's not mandatory. :-)

zzag: Also, it would be great to destroy the client, though that's not mandatory. :-)
81​ KWin::Compositor::self()->addRepaintFull();
82​ QVERIFY(swapSpy.wait());
83​}
84​
85​void BufferSizeChangeTest::testShmBufferSizeChangeOnSubSurface()
86​{
87​ using namespace KWayland::Client;
88​
89​ // setup parent surface
90​ QScopedPointer<Surface> parentSurface(Test::createSurface());
91​ QVERIFY(!parentSurface.isNull());
92​ QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(parentSurface.data()));
93​ QVERIFY(!shellSurface.isNull());
94​
95​ // setup sub surface
96​ QScopedPointer<Surface> surface(Test::createSurface());
97​ QVERIFY(!surface.isNull());
98​ QScopedPointer<SubSurface> subSurface(Test::createSubSurface(surface.data(), parentSurface.data()));
99​ QVERIFY(!subSurface.isNull());
100​
101​ // set buffer sizes
102​ Test::render(surface.data(), QSize(30, 10), Qt::red);
103​ ShellClient *parent = Test::renderAndWaitForShown(parentSurface.data(), QSize(100, 50), Qt::blue);
104​ QVERIFY(parent);
105​
106​ // add a first repaint
107​ QSignalSpy swapSpy(Compositor::self(), &Compositor::bufferSwapCompleted);
108​ QVERIFY(swapSpy.isValid());
109​ Compositor::self()->addRepaintFull();
110​ QVERIFY(swapSpy.wait());
111​
112​ // change buffer size of sub surface
113​ QSignalSpy damagedParentSpy(parent, &ShellClient::damaged);
114​ QVERIFY(damagedParentSpy.isValid());
115​ Test::render(surface.data(), QSize(20, 10), Qt::red);
116​ parentSurface->commit(Surface::CommitFlag::None);
117​
118​ QVERIFY(damagedParentSpy.wait());
119​
120​ // add a second repaint
121​ KWin::Compositor::self()->addRepaintFull();
122​ QVERIFY(swapSpy.wait());
123​}
124​
125​}
126​
127​WAYLANDTEST_MAIN(KWin::BufferSizeChangeTest)
128​#include "buffer_size_change_test.moc"