Differential D17377 Diff 46945 src/activities/money/MoneyCore.qml

Changeset View

Standalone View

View Options

src/activities/money/MoneyCore.qml

Context not available.
59 property alias tuxMoney: tuxMoney 59​ property alias tuxMoney: tuxMoney
60 property alias bar: bar 60​ property alias bar: bar
61 property alias bonus: bonus 61​ property alias bonus: bonus
62​ property int itemIndex
63​ property bool pocketFocus
64​ property var area
65​ property alias pocket : pocket
62 } 66​ }
63 67​
64 onStart: { Activity.start(items, dataset) } 68​ onStart: { Activity.start(items, dataset) }
Context not available.
119 sourceSize.height: column.itemHeight 123​ sourceSize.height: column.itemHeight
120 height: column.itemHeight 124​ height: column.itemHeight
121 125​
126​ property bool selected: false
127​
122 MultiPointTouchArea { 128​ MultiPointTouchArea {
123 anchors.fill: parent 129​ anchors.fill: parent
124 onReleased: Activity.unpay(index) 130​ onReleased: Activity.unpay(index)
125 } 131​ }
132​
133​ Rectangle{
134​ width: parent.width * 1.1
135​ height: parent.height * 1.1
amankumarguptaUnsubmitted
Done

Needs spaces (parent.height * 1.1). Same for above.

amankumargupta: Needs spaces (parent.height * 1.1). Same for above.
136​ color: "#88111111"
137​ anchors.centerIn : parent
amankumarguptaUnsubmitted
Done

spaces before and after : symbol.

amankumargupta: spaces before and after : symbol.
138​ radius: 5
139​ visible: selected
140​ z: -1
amankumarguptaUnsubmitted
Done

Needs space (z: -1)

amankumargupta: Needs space (z: -1)
141​ }
126 } 142​ }
127 } 143​ }
128 } 144​ }
Context not available.
273 sourceSize.height: column.itemHeight 289​ sourceSize.height: column.itemHeight
274 height: column.itemHeight 290​ height: column.itemHeight
275 291​
292​ property bool selected: false
293​
276 MultiPointTouchArea { 294​ MultiPointTouchArea {
277 anchors.fill: parent 295​ anchors.fill: parent
278 onReleased: Activity.pay(index) 296​ onReleased: Activity.pay(index)
279 } 297​ }
298​ Rectangle {
amankumarguptaUnsubmitted
Done

space before {

amankumargupta: space before {
299​ width: parent.width * 1.1
300​ height: parent.height * 1.1
amankumarguptaUnsubmitted
Done

width and height as multiples of 1.1 should be good, as you had done above. Also space needed.

amankumargupta: width and height as multiples of 1.1 should be good, as you had done above. Also space needed.
301​ color: "#88111111"
302​ anchors.centerIn: parent
303​ radius: 5
304​ visible: selected
305​ z: -1
amankumarguptaUnsubmitted
Done

Space needed. Refer above.

amankumargupta: Space needed. Refer above.
306​ }
280 } 307​ }
281 } 308​ }
282 } 309​ }
283 } 310​ }
311​ }
312​
313​
314​ Keys.onPressed: {
315​ if(event.key === Qt.Key_Tab){
316​ if(items.area.count !== 0 && items.itemIndex !== -1)
amankumarguptaUnsubmitted
Done

Empty line not needed here.

amankumargupta: Empty line not needed here.
317​ items.area.itemAt(items.itemIndex).selected = false
318​
amankumarguptaUnsubmitted
Done

Empty line not needed here.

amankumargupta: Empty line not needed here.
319​ if(items.pocketFocus){
amankumarguptaUnsubmitted
Done

Space needed (items.area.count !== 0)

amankumargupta: Space needed (items.area.count !== 0)
320​ items.pocketFocus = false
amankumarguptaUnsubmitted
Done

Space needed (items.area.itemAt(items.itemIndex).selected = false)

amankumargupta: Space needed (items.area.itemAt(items.itemIndex).selected = false)
321​ items.area = answer
322​ }
323​ else {
324​ items.pocketFocus = true
amankumarguptaUnsubmitted
Done

Space needed (items.area = answer)

amankumargupta: Space needed (items.area = answer)
325​ items.area = pocket
326​ }
327​ items.itemIndex = 0
328​ }
amankumarguptaUnsubmitted
Done

Space needed (items.area = pocket)

amankumargupta: Space needed (items.area = pocket)
329​
330​ if(items.area.count !== 0){
amankumarguptaUnsubmitted
Done

Space needed.

amankumargupta: Space needed.
331​ if(items.itemIndex >= 0)
332​ items.area.itemAt(items.itemIndex).selected = false
333​
amankumarguptaUnsubmitted
Done

Space needed, and remove extra space, if(items.area.count !==0) {

amankumargupta: Space needed, and remove extra space, if(items.area.count !==0) {
334​ if(event.key === Qt.Key_Right){
amankumarguptaUnsubmitted
Done

Empty line not needed.

amankumargupta: Empty line not needed.
335​ if(items.itemIndex != (items.area.count-1))
amankumarguptaUnsubmitted
Done

Space needed. Same for the statement below.

amankumargupta: Space needed. Same for the statement below.
336​ items.itemIndex++
337​ else
338​ items.itemIndex = 0
amankumarguptaUnsubmitted
Done

Since you were already using if-else statements above, can you maintain the consistency by replacing the switch case statements with if-else?

amankumargupta: Since you were already using if-else statements above, can you maintain the consistency by…
smitpatilAuthorUnsubmitted
Not Done

I first tried if-else but that took a lot of lines. Thus, I find switch more consistent than if-else. still, if you want, I will implement it.

smitpatil: I first tried if-else but that took a lot of lines. Thus, I find switch more consistent than if…
amankumarguptaUnsubmitted
Done

Well, as far as I can see, the case statements will just be replaced with the if conditional statements. So, the number of lines should technically be around same :) You can once implement it and check ;)

amankumargupta: Well, as far as I can see, the case statements will just be replaced with the if conditional…
339​ }
amankumarguptaUnsubmitted
Done

Extra blank line not needed.

amankumargupta: Extra blank line not needed.
340​ if(event.key === Qt.Key_Left){
341​ if(items.itemIndex > 0)
amankumarguptaUnsubmitted
Done

Space needed on left of != operator.

amankumargupta: Space needed on left of != operator.
342​ items.itemIndex--
343​ else
344​ items.itemIndex = items.area.count-1
345​ }
346​ if([Qt.Key_Space, Qt.Key_Return].indexOf(event.key) != -1){
347​ if(items.pocketFocus)
amankumarguptaUnsubmitted
Done

Space needed.

amankumargupta: Space needed.
348​ Activity.pay(items.itemIndex)
349​ else
350​ Activity.unpay(items.itemIndex)
amankumarguptaUnsubmitted
Done

Space needed after = operator.

amankumargupta: Space needed after = operator.
351​ if(items.itemIndex > 0)
352​ items.itemIndex--
353​ }
354​ }
284 355​
356​
357​ if(items.area.count !== 0 && items.itemIndex !== -1)
358​ items.area.itemAt(items.itemIndex).selected = true
amankumarguptaUnsubmitted
Done

Space needed

amankumargupta: Space needed
285 } 359​ }
286 360​
287 361​
amankumarguptaUnsubmitted
Done

Empty line not needed.

amankumargupta: Empty line not needed.
362​
288 DialogHelp { 363​ DialogHelp {
289 id: dialogHelp 364​ id: dialogHelp
amankumarguptaUnsubmitted
Done

Space needed on sides of = operator

amankumargupta: Space needed on sides of = operator
290 onClose: home() 365​ onClose: home()
Context not available.
amankumarguptaUnsubmitted
Done

Empty line not needed.

amankumargupta: Empty line not needed.
amankumarguptaUnsubmitted
Done

One extra empty line not needed.

amankumargupta: One extra empty line not needed.