Differential D17214 Diff 46420 smsapp/conversationlistmodel.cpp

Changeset View

Standalone View

View Options

smsapp/conversationlistmodel.cpp

Context not available.
166 appendRow(item); 166​ appendRow(item);
167} 167​}
168 168​
169​void ConversationListModel::createRowFromAddress(const QString& address) {
170​ QScopedPointer<KPeople::PersonData> personData(lookupPersonByAddress(address));
171​ QStandardItem* item = new QStandardItem();
172​ if (personData) {
173​ item->setText(personData->name());
174​ item->setIcon(QIcon(personData->photo()));
175​ item->setData(personData->personUri(), PersonUriRole);
176​ } else {
177​ item->setData(QString(), PersonUriRole);
178​ item->setText(address);
179​ }
180​ item->setData(address.toInt(), ConversationIdRole);
181​ item->setData(address, AddressRole);
182​ item->setData(ConversationMessage::MessageTypeSent, FromMeRole);
183​ item->setData("[New conversation]", Qt::ToolTipRole);
sredmanAuthorUnsubmitted
Not Done

@apol How do we make this translate-able?

sredman: @apol How do we make this translate-able?
nicolasfellaUnsubmitted
Not Done

i18n("Text")

nicolasfella: i18n("Text")
184​ item->setData(1, DateRole);
sredmanAuthorUnsubmitted
Not Done

Do you need to specify this? What happens if you leave it out?

sredman: Do you need to specify this? What happens if you leave it out?
185​ appendRow(item);
sredmanAuthorUnsubmitted
Not Done

This is a good idea! However, since it is code that was copy-pasted from another method ("createRowFromMessage") could you make a helper function which can be used by both of those? For instance, maybe something like "createItemFromMessage" which returns QStandardItem*. That method gets used directly by "createRowFromMessage". This method ("createRowFromAddress") would construct the dummy message with the dummy "[New Conversation]" body and timestamp, then call the same helper

sredman: This is a good idea! However, since it is code that was copy-pasted from another method…
186​}
187​
169KPeople::PersonData* ConversationListModel::lookupPersonByAddress(const QString& address) 188​KPeople::PersonData* ConversationListModel::lookupPersonByAddress(const QString& address)
170{ 189​{
171 const QString& canonicalAddress = canonicalizePhoneNumber(address); 190​ const QString& canonicalAddress = canonicalizePhoneNumber(address);
Context not available.