Changeset View
Changeset View
Standalone View
Standalone View
effects/wobblywindows/wobblywindows.h
Context not available. | |||||
139 | void cancelWindowGrab(KWin::EffectWindow *w, int grabRole); | 139 | void cancelWindowGrab(KWin::EffectWindow *w, int grabRole); | ||
---|---|---|---|---|---|
140 | void startMovedResized(EffectWindow* w); | 140 | void startMovedResized(EffectWindow* w); | ||
141 | void stepMovedResized(EffectWindow* w); | 141 | void stepMovedResized(EffectWindow* w); | ||
142 | bool updateWindowWobblyDatas(EffectWindow* w, qreal time); | | |||
143 | 142 | | |||
zzag: Please revert this change. | |||||
144 | struct WindowWobblyInfos { | 143 | struct WindowWobblyInfos { | ||
145 | Pair* origin; | 144 | Pair* origin; | ||
Context not available. | |||||
171 | QRect resize_original_rect; | 170 | QRect resize_original_rect; | ||
172 | }; | 171 | }; | ||
173 | 172 | | |||
173 | bool updateWindowWobblyDatas(WindowWobblyInfos& wwi, const QRectF& rect, qreal time); | ||||
174 | | ||||
175 | void initWobblyInfo(WindowWobblyInfos& wwi, const QRectF& geometry) const; | ||||
176 | void freeWobblyInfo(WindowWobblyInfos& wwi) const; | ||||
177 | void wobblyOpenInit(WindowWobblyInfos& wwi) const; | ||||
178 | void wobblyCloseInit(WindowWobblyInfos& wwi, EffectWindow* w) const; | ||||
179 | | ||||
180 | WobblyWindowsEffect::Pair computeBezierPoint(const WindowWobblyInfos& wwi, const Pair& point) const; | ||||
181 | | ||||
182 | static void heightRingLinearMean(Pair** data_pointer, WindowWobblyInfos& wwi); | ||||
183 | | ||||
184 | void setParameterSet(const ParameterSet& pset); | ||||
185 | | ||||
174 | QHash< const EffectWindow*, WindowWobblyInfos > windows; | 186 | QHash< const EffectWindow*, WindowWobblyInfos > windows; | ||
175 | 187 | | |||
176 | QRegion m_updateRegion; | 188 | QRegion m_updateRegion; | ||
Functions should be listed before member variables with same scope. The old code did this wrong already though. romangg: Functions should be listed before member variables with same scope. The old code did this wrong… | |||||
Context not available. | |||||
198 | 210 | | |||
199 | bool m_moveWobble; // Expands m_moveEffectEnabled | 211 | bool m_moveWobble; // Expands m_moveEffectEnabled | ||
200 | bool m_resizeWobble; | 212 | bool m_resizeWobble; | ||
201 | | ||||
202 | void initWobblyInfo(WindowWobblyInfos& wwi, QRect geometry) const; | | |||
203 | void freeWobblyInfo(WindowWobblyInfos& wwi) const; | | |||
204 | void wobblyOpenInit(WindowWobblyInfos& wwi) const; | | |||
205 | void wobblyCloseInit(WindowWobblyInfos& wwi, EffectWindow* w) const; | | |||
206 | | ||||
207 | WobblyWindowsEffect::Pair computeBezierPoint(const WindowWobblyInfos& wwi, Pair point) const; | | |||
208 | | ||||
209 | static void heightRingLinearMean(Pair** data_pointer, WindowWobblyInfos& wwi); | | |||
210 | | ||||
211 | void setParameterSet(const ParameterSet& pset); | | |||
zzag: Please leave them here. (Move them up in a patch that does code cleanup) | |||||
See above comment from @romangg anthonyfieroni: See above comment from @romangg | |||||
212 | }; | 213 | }; | ||
213 | 214 | | |||
214 | } // namespace KWin | 215 | } // namespace KWin | ||
Context not available. |
Please revert this change.