Differential D15704 Diff 42521 src/writers/taglibwriter.cpp

Changeset View

Standalone View

src/writers/taglibwriter.cpp

Show All 13 Lines
14		14
15	TagLib::String q2t(const QString& q)	15		TagLib::String q2t(const QString& q)
16	{	16		{
17	return TagLib::String(q.toStdWString());	17		return TagLib::String(q.toStdWString());
18	}	18		}
19		19
20	QStringList TagLibWriter::writeMimetypes() const	20		QStringList TagLibWriter::writeMimetypes() const
21	{	21		{
22	QStringList types = {	22		QStringList types = {
		23		QStringLiteral("audio/flac"),
		24		QStringLiteral("audio/mp4"),
			svuorelaUnsubmitted Not Done Unrelated. but consider making this static ? svuorela: Unrelated. but consider making this static ?
			astippichAuthorUnsubmitted Not Done Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that for all at once and separately astippich: Never really though about that, but should be static, yes. None of the writers and extractors I…
23	QStringLiteral("audio/mpeg"),	25		QStringLiteral("audio/mpeg"),
			brunsUnsubmitted Not Done Can you also order these alphabetically based on the main mime type (aliases immediate after)? bruns: Can you also order these alphabetically based on the main mime type (aliases immediate after)?
24	QStringLiteral("audio/mpeg3"),	26		QStringLiteral("audio/mpeg3"),
25	QStringLiteral("audio/x-mpeg"),	27		QStringLiteral("audio/ogg"),
26	QStringLiteral("audio/opus"),	28		QStringLiteral("audio/opus"),
27	QStringLiteral("audio/x-opus+ogg")	29		QStringLiteral("audio/x-mpeg"),
		30		QStringLiteral("audio/x-musepack"),
			brunsUnsubmitted Not Done audio/wav and the next three are not backed by tests AFAICS, can you add these in a separate review, accompanied by tests files? bruns: audio/wav and the next three are not backed by tests AFAICS, can you add these in a separate…
		31		QStringLiteral("audio/x-opus+ogg"),
		32		QStringLiteral("audio/x-vorbis+ogg"),
28	};	33		};
29		34
30	return types;	35		return types;
31	}	36		}
32		37
33	void TagLibWriter::write(const WriteData& data)	38		void TagLibWriter::write(const WriteData& data)
34	{	39		{
35	const QString fileUrl = data.inputUrl();	40		const QString fileUrl = data.inputUrl();
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines