Differential D15704 Diff 42521 autotests/taglibwritertest.cpp

Changeset View

Standalone View

View Options

autotests/taglibwritertest.cpp

1#include "taglibwritertest.h" 1​#include "taglibwritertest.h"
2#include "indexerextractortestsconfig.h" 2​#include "indexerextractortestsconfig.h"
3#include "writers/taglibwriter.h" 3​#include "writers/taglibwriter.h"
4#include "writedata.h" 4​#include "writedata.h"
5 5​
6#include "taglib.h" 6​#include "taglib.h"
7#include "fileref.h" 7​#include "fileref.h"
8 8​
9#include <QDebug> 9​#include <QDebug>
10#include <QTest> 10​#include <QTest>
11#include <QDir> 11​#include <QDir>
12#include <QFile> 12​#include <QFile>
13 13​
14#define TEST_FILENAME "writertest.opus" ​
15 ​
16using namespace KFileMetaData; 14​using namespace KFileMetaData;
17 15​
18static QString t2q(const TagLib::String& t) 16​static QString t2q(const TagLib::String& t)
19{ 17​{
20 return QString::fromWCharArray((const wchar_t*)t.toCWString(), t.length()); 18​ return QString::fromWCharArray((const wchar_t*)t.toCWString(), t.length());
21} 19​}
22 20​
23QString TagLibWriterTest::testFilePath(const QString& fileName) const 21​QString TagLibWriterTest::testFilePath(const QString& fileName) const
24{ 22​{
25 return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + QDir::separator() + fileName; 23​ return QLatin1String(INDEXER_TESTS_SAMPLE_FILES_PATH) + QDir::separator() + fileName;
26} 24​}
27 25​
28void TagLibWriterTest::initTestCase() 26​void TagLibWriterTest::testCommonData()
29{ 27​{
30 QFile testFile(testFilePath("test.opus")); 28​ QFETCH(QString, fileType);
31 QFile writerTestFile(testFilePath(TEST_FILENAME)); 29​ QFETCH(QString, mimeType);
32 QFile::copy(testFilePath("test.opus"), testFilePath(TEST_FILENAME)); ​
33} ​
34 30​
35void TagLibWriterTest::test() 31​ QString temporaryFileName = QStringLiteral("writertest.") + fileType;
36{ 32​
33​ QFile::copy(testFilePath("test." + fileType), testFilePath(temporaryFileName));
37 TagLibWriter writerPlugin{this}; 34​ TagLibWriter writerPlugin{this};
35​ QCOMPARE(writerPlugin.writeMimetypes().contains(mimeType),true);
38 36​
39 WriteData data(testFilePath(TEST_FILENAME), "audio/opus"); 37​ WriteData data(testFilePath(temporaryFileName), mimeType);
40 data.add(Property::Title, "Title1"); 38​ data.add(Property::Title, "Title1");
41 data.add(Property::Artist, "Artist1"); 39​ data.add(Property::Artist, "Artist1");
42 data.add(Property::Album, "Album1"); 40​ data.add(Property::Album, "Album1");
43 data.add(Property::TrackNumber, 10); 41​ data.add(Property::TrackNumber, 10);
44 data.add(Property::ReleaseYear, 1999); 42​ data.add(Property::ReleaseYear, 1999);
45 data.add(Property::Genre, "Genre1"); 43​ data.add(Property::Genre, "Genre1");
46 data.add(Property::Comment, "Comment1"); 44​ data.add(Property::Comment, "Comment1");
47 writerPlugin.write(data); 45​ writerPlugin.write(data);
48 46​
49 TagLib::FileRef file(testFilePath(TEST_FILENAME).toUtf8().constData(), true); 47​ TagLib::FileRef file(testFilePath(temporaryFileName).toUtf8().constData(), true);
50 TagLib::Tag* tags = file.tag(); 48​ TagLib::Tag* tags = file.tag();
51 49​
52 QString extractedTitle = t2q(tags->title()); 50​ QString extractedTitle = t2q(tags->title());
53 QString extractedArtist = t2q(tags->artist()); 51​ QString extractedArtist = t2q(tags->artist());
54 QString extractedAlbum = t2q(tags->album()); 52​ QString extractedAlbum = t2q(tags->album());
55 uint extractedTrackNumber = tags->track(); 53​ uint extractedTrackNumber = tags->track();
56 uint extractedYear = tags->year(); 54​ uint extractedYear = tags->year();
57 QString extractedGenre = t2q(tags->genre()); 55​ QString extractedGenre = t2q(tags->genre());
58 QString extractedComment = t2q(tags->comment()); 56​ QString extractedComment = t2q(tags->comment());
59 57​
60 QCOMPARE(extractedTitle, QStringLiteral("Title1")); 58​ QCOMPARE(extractedTitle, QStringLiteral("Title1"));
61 QCOMPARE(extractedArtist, QStringLiteral("Artist1")); 59​ QCOMPARE(extractedArtist, QStringLiteral("Artist1"));
62 QCOMPARE(extractedAlbum, QStringLiteral("Album1")); 60​ QCOMPARE(extractedAlbum, QStringLiteral("Album1"));
63 QCOMPARE(extractedTrackNumber, 10u); 61​ QCOMPARE(extractedTrackNumber, 10u);
64 QCOMPARE(extractedYear, 1999u); 62​ QCOMPARE(extractedYear, 1999u);
65 QCOMPARE(extractedGenre, QStringLiteral("Genre1")); 63​ QCOMPARE(extractedGenre, QStringLiteral("Genre1"));
66 QCOMPARE(extractedComment, QStringLiteral("Comment1")); 64​ QCOMPARE(extractedComment, QStringLiteral("Comment1"));
65​
66​ QFile::remove(testFilePath(temporaryFileName));
67} 67​}
68 68​
69void TagLibWriterTest::cleanupTestCase() 69​void TagLibWriterTest::testCommonData_data()
70{ 70​{
71 QFile::remove(testFilePath(TEST_FILENAME)); 71​ QTest::addColumn<QString>("fileType");
72​ QTest::addColumn<QString>("mimeType");
73​
74​ QTest::addRow("flac")
brunsUnsubmitted
Not Done

Can you sort the tests alphabetically? It does not matter much, but IMHO it is nicer to have some rule for ordering, instead of arbitrary order.

bruns: Can you sort the tests alphabetically? It does not matter much, but IMHO it is nicer to have…
75​ << QStringLiteral("flac")
76​ << QStringLiteral("audio/flac")
77​ ;
78​
79​ QTest::addRow("m4a")
80​ << QStringLiteral("m4a")
81​ << QStringLiteral("audio/mp4")
82​ ;
83​
84​ QTest::addRow("mp3")
85​ << QStringLiteral("mp3")
86​ << QStringLiteral("audio/mpeg3")
87​ ;
88​
89​ QTest::addRow("mpc")
90​ << QStringLiteral("mpc")
91​ << QStringLiteral("audio/x-musepack")
92​ ;
93​
94​ QTest::addRow("ogg")
95​ << QStringLiteral("ogg")
96​ << QStringLiteral("audio/ogg")
97​ ;
98​
99​ QTest::addRow("opus")
100​ << QStringLiteral("opus")
101​ << QStringLiteral("audio/opus")
102​ ;
72} 103​}
73 104​
74QTEST_GUILESS_MAIN(TagLibWriterTest) 105​QTEST_GUILESS_MAIN(TagLibWriterTest)