Changeset View
Changeset View
Standalone View
Standalone View
gui/ksysguard.cpp
Context not available. | |||||
70 | #include <ksgrd/SensorManager.h> | 70 | #include <ksgrd/SensorManager.h> | ||
---|---|---|---|---|---|
71 | #include <processui/ksysguardprocesslist.h> | 71 | #include <processui/ksysguardprocesslist.h> | ||
72 | 72 | | |||
73 | | ||||
74 | //Comment out to stop ksysguard from forking. Good for debugging | 73 | //Comment out to stop ksysguard from forking. Good for debugging | ||
ngraham: Unrelated whitespace change | |||||
75 | //#define FORK_KSYSGUARD | 74 | //#define FORK_KSYSGUARD | ||
76 | 75 | | |||
Context not available. | |||||
148 | 147 | | |||
149 | // setup 'Settings' menu | 148 | // setup 'Settings' menu | ||
ngraham: Extra whitespace | |||||
@broulik just pointed out that KStandardAction has gained support for the more modern slot syntax. So, ideally this line should be changed to mShowMenuBarAction = KStandardAction::showMenubar(this, &TopLevel::toggleShowMenuBar, actionCollection()); Which has the advantage of letting the compiler assert slot compatibility, whereas the old SLOT() syntax turns it into a runtime problem which is easy to miss should it break in the future. Not technically a blocking issue though. sitter: @broulik just pointed out that KStandardAction has gained support for the more modern slot… | |||||
150 | KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection()); | 149 | KToggleAction* showMenuBar = KStandardAction::showMenubar(nullptr, nullptr, actionCollection()); | ||
Minor nitpick: "setup" is a noun; it should be "set up" so that there's a verb in the sentence. ngraham: Minor nitpick: "setup" is a noun; it should be "set up" so that there's a verb in the sentence. | |||||
151 | connect(showMenuBar, &KToggleAction::triggered, // Fixes #286822 | 150 | connect(showMenuBar, &KToggleAction::triggered, | ||
152 | this, &TopLevel::toggleShowMenuBar, Qt::QueuedConnection); | 151 | this, &TopLevel::toggleShowMenuBar, Qt::QueuedConnection); | ||
153 | 152 | | |||
154 | retranslateUi(); | 153 | retranslateUi(); | ||
Context not available. |
Unrelated whitespace change