Changeset View
Changeset View
Standalone View
Standalone View
effects/fadedesktop/package/contents/code/main.js
Show All 34 Lines | 31 | for (var i=0; i<stackingOrder.length; i++) { | |||
---|---|---|---|---|---|
35 | } | 35 | } | ||
36 | if (w.minimized) { | 36 | if (w.minimized) { | ||
37 | continue; | 37 | continue; | ||
38 | } | 38 | } | ||
39 | if (!w.isOnActivity(effects.currentActivity)){ | 39 | if (!w.isOnActivity(effects.currentActivity)){ | ||
40 | continue; | 40 | continue; | ||
41 | } | 41 | } | ||
42 | if (w.desktop == oldDesktop) { | 42 | if (w.desktop == oldDesktop) { | ||
43 | effect.animate(w, Effect.Opacity, duration, 0.0); | 43 | animate({ | ||
44 | window: w, | ||||
45 | duration: duration, | ||||
46 | animations: [{ | ||||
47 | type: Effect.Opacity, | ||||
48 | to: 0.0 | ||||
49 | }] | ||||
50 | }); | ||||
44 | } else { | 51 | } else { | ||
45 | effect.animate(w, Effect.Opacity, duration, w.opacity, 0.0); | 52 | animate({ | ||
53 | window: w, | ||||
54 | duration: duration, | ||||
55 | animations: [{ | ||||
56 | type: Effect.Opacity, | ||||
57 | to: w.opacity, | ||||
zzag: Should it be 1.0? | |||||
This matches the previous code, but arguably yes it should AnimationEffect::paintWindow is (correctly) using WindowPaintData::multiplyOpacity not setOpacity and WindowPaintData::opacity defaults to the window opacity davidedmundson: This matches the previous code, but arguably yes it should
AnimationEffect::paintWindow
is… | |||||
58 | from: 0.0 | ||||
59 | }] | ||||
60 | }); | ||||
46 | } | 61 | } | ||
47 | } | 62 | } | ||
48 | }); | 63 | }); |
Should it be 1.0?