[effects/fadedesktop] Port to explicit animate API
ClosedPublic

Authored by davidedmundson on Sep 13 2018, 10:03 AM.

Details

Summary

No behavioural changes

Test Plan

Set a slow animation speed
Changed desktop

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2790
Build 2808: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptSep 13 2018, 10:03 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Sep 13 2018, 10:03 AM
zzag added a subscriber: zzag.Sep 13 2018, 10:44 AM
zzag added inline comments.
effects/fadedesktop/package/contents/code/main.js
57

Should it be 1.0?

effects/fadedesktop/package/contents/code/main.js
57

This matches the previous code, but arguably yes it should

AnimationEffect::paintWindow

is (correctly) using WindowPaintData::multiplyOpacity not setOpacity

and WindowPaintData::opacity defaults to the window opacity

zzag accepted this revision.Sep 13 2018, 11:57 AM
This revision is now accepted and ready to land.Sep 13 2018, 11:57 AM
This revision was automatically updated to reflect the committed changes.