Changeset View
Standalone View
kdevplatform/vcs/CMakeLists.txt
Show All 40 Lines | 17 | set(KDevPlatformVcs_LIB_SRCS | |||
---|---|---|---|---|---|
41 | dvcs/ui/dvcsimportmetadatawidget.cpp | 41 | dvcs/ui/dvcsimportmetadatawidget.cpp | ||
42 | dvcs/ui/branchmanager.cpp | 42 | dvcs/ui/branchmanager.cpp | ||
43 | interfaces/ibasicversioncontrol.cpp | 43 | interfaces/ibasicversioncontrol.cpp | ||
44 | interfaces/icontentawareversioncontrol.cpp | 44 | interfaces/icontentawareversioncontrol.cpp | ||
45 | interfaces/ipatchdocument.cpp | 45 | interfaces/ipatchdocument.cpp | ||
46 | interfaces/ipatchsource.cpp | 46 | interfaces/ipatchsource.cpp | ||
47 | ) | 47 | ) | ||
48 | 48 | | |||
49 | if(NOT KF5TextEditor_VERSION VERSION_LESSER 5.52.0) | ||||
apol: I wouldn't compile it conditionally. Let's just bump the frameworks dependency once this is in.. | |||||
Sure about this? Developers on rolling releases might have no problems with such a dependency bump, anyone else though would, no? :) kossebau: Sure about this? Developers on rolling releases might have no problems with such a dependency… | |||||
The rest can use the appimage or the flatpak or snap or docker or create their own packaging system... IMHO apol: The rest can use the appimage or the flatpak or snap or docker or create their own packaging… | |||||
Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using ubuntu will be able to self-compile KDevelop easily before mid-next-year, it means we have to rebuild our windows dependency chain (which in the past always turned out to be at least a day's worth of fiddling), and so on. It's simply not worth it. Let's keep the ifdef and wait for more things depending on later KF5 to come up before we bump the requirement. brauch: Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using… | |||||
+1 on Sven's remarks. @kossebau Why's that still commented? kfunk: +1 on Sven's remarks.
@kossebau Why's that still commented? | |||||
xD in fairness, v5.40.0 nowadays is older than the last Ubuntu LTS release and it should be fine to have it included there unconditionally. apol: xD in fairness, v5.40.0 nowadays is older than the last Ubuntu LTS release and it should be… | |||||
50 | list(APPEND KDevPlatformVcs_LIB_SRCS | ||||
51 | widgets/vcsannotationitemdelegate.cpp | ||||
52 | ) | ||||
53 | endif() | ||||
54 | | ||||
49 | ecm_qt_declare_logging_category(KDevPlatformVcs_LIB_SRCS | 55 | ecm_qt_declare_logging_category(KDevPlatformVcs_LIB_SRCS | ||
50 | HEADER debug.h | 56 | HEADER debug.h | ||
51 | IDENTIFIER VCS | 57 | IDENTIFIER VCS | ||
52 | CATEGORY_NAME "kdevplatform.vcs" | 58 | CATEGORY_NAME "kdevplatform.vcs" | ||
53 | ) | 59 | ) | ||
54 | 60 | | |||
55 | ki18n_wrap_ui(KDevPlatformVcs_LIB_SRCS ${KDevPlatformVcs_UIS}) | 61 | ki18n_wrap_ui(KDevPlatformVcs_LIB_SRCS ${KDevPlatformVcs_UIS}) | ||
56 | kdevplatform_add_library(KDevPlatformVcs SOURCES ${KDevPlatformVcs_LIB_SRCS}) | 62 | kdevplatform_add_library(KDevPlatformVcs SOURCES ${KDevPlatformVcs_LIB_SRCS}) | ||
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines |
I wouldn't compile it conditionally. Let's just bump the frameworks dependency once this is in...