Differential D15306 Diff 41125 runners/bookmarks/bookmarksrunner.cpp

Changeset View

Standalone View

runners/bookmarks/bookmarksrunner.cpp

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Line(s)
55		55
56	BookmarksRunner::~BookmarksRunner()	56		BookmarksRunner::~BookmarksRunner()
57	{	57		{
58	}	58		}
59		59
60		60
61	void BookmarksRunner::prep()	61		void BookmarksRunner::prep()
62	{	62		{
63	m_browser = m_browserFactory->find(findBrowserName(), this);	63		auto browser = m_browserFactory->find(findBrowserName(), this);
64	connect(this, SIGNAL(teardown()), dynamic_cast<QObject*>(m_browser), SLOT(teardown()));	64		if (m_browser != browser) {
		65		m_browser = browser;
			davidedmundsonUnsubmitted Done do we not also need a disconnect on m_browser? davidedmundson: do we not also need a disconnect on m_browser?
			brunsAuthorUnsubmitted Done Browser is just an interface class, but the subclasses also derive from QObject and should auto-disconnect, AFAIK. bruns: Browser is just an interface class, but the subclasses also derive from QObject and should auto…
		66		connect(this, &Plasma::AbstractRunner::teardown,
			broulikUnsubmitted Done Please provide `this` as context. broulik: Please provide `this` as context.
			brunsAuthorUnsubmitted Done you mean `this->mbrowser->teardown()`? bruns: you mean `this->mbrowser->teardown()`?
			broulikUnsubmitted Done No, four-argument connect: connect(this, &..., this, .... Though you just connect from `this` anyway, so I guess this isn't needed broulik: No, four-argument connect: ``` connect(this, &..., this, .... ``` Though you just connect from…
			brunsAuthorUnsubmitted Done Hm, just found that auto-disconnect (see @davidedmundson s comment) only works if you provide a context. The context has to be `m_browser` here. bruns: Hm, just found that auto-disconnect (see @davidedmundson s comment) only works if you provide a…
			broulikUnsubmitted Done Ah, yeah, right, and then you could connect direcftly: connect(this, &Plasma::AbstractRunner:teardown, m_browser, &Browser::teardown); broulik: Ah, yeah, right, and then you could connect direcftly: ``` connect(this, &Plasma…
			brunsAuthorUnsubmitted Done yes, after readding the `dynamic_cast<QObject>`, m_browser is a non-QObject interface class. bruns:* yes, after readding the `dynamic_cast<QObject*>`, m_browser is a non-QObject interface class.
			brunsAuthorUnsubmitted Not Done The only syntax which works is connect(this, &Plasma::AbstractRunner:teardown, dynamic_cast<QObject>(m_browser), [this] () { m_browser->teardown(); }); The context object has to be a QObject (or derived). &Browser::teardown is not a pointer to a QObject member function, thus we need a functor. The other approach would be to make Browser a QObject derived class. bruns: The only syntax which works is ``` connect(this, &Plasma::AbstractRunner:teardown…
		67		dynamic_cast<QObject*>(m_browser), [this] () { m_browser->teardown(); });
		68		}
65	m_browser->prepare();	69		m_browser->prepare();
66	}	70		}
67		71
68		72
69		73
70	void BookmarksRunner::match(Plasma::RunnerContext &context)	74		void BookmarksRunner::match(Plasma::RunnerContext &context)
71	{	75		{
72	if(! m_browser) return;	76		if(! m_browser) return;
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines