Differential D8709 Diff 40991 kdevplatform/vcs/CMakeLists.txt

Changeset View

Standalone View

kdevplatform/vcs/CMakeLists.txt

Show All 40 Lines		17	set(KDevPlatformVcs_LIB_SRCS
41	dvcs/ui/dvcsimportmetadatawidget.cpp	41		dvcs/ui/dvcsimportmetadatawidget.cpp
42	dvcs/ui/branchmanager.cpp	42		dvcs/ui/branchmanager.cpp
43	interfaces/ibasicversioncontrol.cpp	43		interfaces/ibasicversioncontrol.cpp
44	interfaces/icontentawareversioncontrol.cpp	44		interfaces/icontentawareversioncontrol.cpp
45	interfaces/ipatchdocument.cpp	45		interfaces/ipatchdocument.cpp
46	interfaces/ipatchsource.cpp	46		interfaces/ipatchsource.cpp
47	)	47		)
48		48
		49		# if(KF5TextEditor_VERSION VERSION_GREATER 5.40.0)
			apolUnsubmitted Not Done I wouldn't compile it conditionally. Let's just bump the frameworks dependency once this is in... apol: I wouldn't compile it conditionally. Let's just bump the frameworks dependency once this is in..
			kossebauAuthorUnsubmitted Not Done Sure about this? Developers on rolling releases might have no problems with such a dependency bump, anyone else though would, no? :) kossebau: Sure about this? Developers on rolling releases might have no problems with such a dependency…
			apolUnsubmitted Not Done The rest can use the appimage or the flatpak or snap or docker or create their own packaging system... IMHO apol: The rest can use the appimage or the flatpak or snap or docker or create their own packaging…
			brauchUnsubmitted Not Done Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using ubuntu will be able to self-compile KDevelop easily before mid-next-year, it means we have to rebuild our windows dependency chain (which in the past always turned out to be at least a day's worth of fiddling), and so on. It's simply not worth it. Let's keep the ifdef and wait for more things depending on later KF5 to come up before we bump the requirement. brauch: Sorry Aleix, I'm strongly against this. Requiring KF5 5.40 effectively means nobody using…
			kfunkUnsubmitted Not Done +1 on Sven's remarks. @kossebau Why's that still commented? kfunk: +1 on Sven's remarks. @kossebau Why's that still commented?
			apolUnsubmitted Not Done xD in fairness, v5.40.0 nowadays is older than the last Ubuntu LTS release and it should be fine to have it included there unconditionally. apol: xD in fairness, v5.40.0 nowadays is older than the last Ubuntu LTS release and it should be…
		50		add_definitions(-DUSE_ANNOTATIONITEMDELEGATE)
		51		list(APPEND KDevPlatformVcs_LIB_SRCS
		52		widgets/vcsannotationitemdelegate.cpp
		53		)
		54		# endif()
		55
49	ecm_qt_declare_logging_category(KDevPlatformVcs_LIB_SRCS	56		ecm_qt_declare_logging_category(KDevPlatformVcs_LIB_SRCS
50	HEADER debug.h	57		HEADER debug.h
51	IDENTIFIER VCS	58		IDENTIFIER VCS
52	CATEGORY_NAME "kdevplatform.vcs"	59		CATEGORY_NAME "kdevplatform.vcs"
53	)	60		)
54		61
55	ki18n_wrap_ui(KDevPlatformVcs_LIB_SRCS ${KDevPlatformVcs_UIS})	62		ki18n_wrap_ui(KDevPlatformVcs_LIB_SRCS ${KDevPlatformVcs_UIS})
56	kdevplatform_add_library(KDevPlatformVcs SOURCES ${KDevPlatformVcs_LIB_SRCS})	63		kdevplatform_add_library(KDevPlatformVcs SOURCES ${KDevPlatformVcs_LIB_SRCS})
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines