Differential D14533 Diff 40065 autotests/integration/effects/scripts/effectsHandler.js

Changeset View

Standalone View

View Options

autotests/integration/effects/scripts/effectsHandler.js

1effects.windowAdded.connect(function(window) { 1​effects.windowAdded.connect(function(window) {
2 sendTestResponse("windowAdded - " + window.caption); 2​ sendTestResponse("windowAdded - " + window.caption);
3​ sendTestResponse("stackingOrder - " + effects.stackingOrder.length + " " + effects.stackingOrder[0].caption);
zzagUnsubmitted
Not Done
var currentStackingOrder = effects.stackingOrder
    .map(function (window) { return window.caption; })
    .join();
sendTestResponse("stackingOrder - " + effects.stackingOrder.length + " " + currentStackingOrder);

I think it would be better.

zzag: ```lang=cpp var currentStackingOrder = effects.stackingOrder .map(function (window) {…
davidedmundsonAuthorUnsubmitted
Not Done

If this was "real" code, absolutely. It would be wrong to have any unchecked array access.

But for a test, if you had anything other than 1 window we're going to abort anyway, and in unit tests I want to get errors.

davidedmundson: If this was "real" code, absolutely. It would be wrong to have any unchecked array access. But…
3}); 4​});
4effects.windowClosed.connect(function(window) { 5​effects.windowClosed.connect(function(window) {
5 sendTestResponse("windowClosed - " + window.caption); 6​ sendTestResponse("windowClosed - " + window.caption);
6}); 7​});
7effects.windowMinimized.connect(function(window) { 8​effects.windowMinimized.connect(function(window) {
8 sendTestResponse("windowMinimized - " + window.caption); 9​ sendTestResponse("windowMinimized - " + window.caption);
9}); 10​});
10effects.windowUnminimized.connect(function(window) { 11​effects.windowUnminimized.connect(function(window) {
11 sendTestResponse("windowUnminimized - " + window.caption); 12​ sendTestResponse("windowUnminimized - " + window.caption);
12}); 13​});
13effects['desktopChanged(int,int)'].connect(function(old, current) { 14​effects['desktopChanged(int,int)'].connect(function(old, current) {
14 sendTestResponse("desktopChanged - " + old + " " + current); 15​ sendTestResponse("desktopChanged - " + old + " " + current);
15}); 16​});