Differential D14437 Diff 38648 src/platformtheme/kdeplatformfiledialoghelper.cpp

Changeset View

Standalone View

src/platformtheme/kdeplatformfiledialoghelper.cpp

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Line(s)		100	{
109	// Also call the cancel function when the dialog is closed via the escape key	109		// Also call the cancel function when the dialog is closed via the escape key
110	// or titlebar close button to make sure we always save the view config	110		// or titlebar close button to make sure we always save the view config
111	connect(this, &KDEPlatformFileDialog::rejected,	111		connect(this, &KDEPlatformFileDialog::rejected,
112	m_fileWidget, &KFileWidget::slotCancel);	112		m_fileWidget, &KFileWidget::slotCancel);
113	connect(m_fileWidget->okButton(), SIGNAL(clicked(bool)), m_fileWidget, SLOT(slotOk()));	113		connect(m_fileWidget->okButton(), SIGNAL(clicked(bool)), m_fileWidget, SLOT(slotOk()));
114	connect(m_fileWidget, SIGNAL(accepted()), m_fileWidget, SLOT(accept()));	114		connect(m_fileWidget, SIGNAL(accepted()), m_fileWidget, SLOT(accept()));
115	connect(m_fileWidget, SIGNAL(accepted()), SLOT(accept()));	115		connect(m_fileWidget, SIGNAL(accepted()), SLOT(accept()));
116	connect(m_fileWidget->cancelButton(), SIGNAL(clicked(bool)), SLOT(reject()));	116		connect(m_fileWidget->cancelButton(), SIGNAL(clicked(bool)), SLOT(reject()));
		117		connect(m_fileWidget->dirOperator(), &KDirOperator::urlEntered, this, &KDEPlatformFileDialogBase::directoryEntered);
		118		// ## no connect to fileSelected, filesSelected, fileHighlighted, currentChanged?
			apolUnsubmitted Not Done I'm not sure I understand the comment. Is it like a TODO? apol: I'm not sure I understand the comment. Is it like a TODO?
			anthonyfieroniUnsubmitted Not Done It works without comment, i think these connections are not needed. anthonyfieroni: It works without comment, i think these connections are not needed.
			dfaureAuthorUnsubmitted Not Done Yes for this problem my patch is enough, but I was surprised to find that those signals were not connected. Yes it's a TODO, but unrelated to this bug. dfaure: Yes for this problem my patch is enough, but I was surprised to find that those signals were…
117	layout()->addWidget(m_buttons);	119		layout()->addWidget(m_buttons);
118	}	120		}
119		121
120	QUrl KDEPlatformFileDialog::directory()	122		QUrl KDEPlatformFileDialog::directory()
121	{	123		{
122	return m_fileWidget->baseUrl();	124		return m_fileWidget->baseUrl();
123	}	125		}
124		126
▲ Show 20 Lines • Show All 313 Lines • Show Last 20 Lines