Differential D14329 Diff 38381 lib/redeyereduction/redeyereductionwidget.ui

Changeset View

Standalone View

View Options

lib/redeyereduction/redeyereductionwidget.ui

Show All 28 Lines21 <item>
29 </widget> 29​ </widget>
30 </item> 30​ </item>
31 <item> 31​ <item>
32 <widget class="QSlider" name="diameterSlider"> 32​ <widget class="QSlider" name="diameterSlider">
33 <property name="minimum"> 33​ <property name="minimum">
34 <number>2</number> 34​ <number>2</number>
35 </property> 35​ </property>
36 <property name="maximum"> 36​ <property name="maximum">
37 <number>40</number> 37​ <number>99</number>
rkflxUnsubmitted
Done

In my patch I also came to the conclusion to increase this. I chose 80 (doubling the initial size), but 99 is probably also okay.

Still, here you are setting an explicit value, while for the spinbox the implicit default of 99 is used. I'd say you should also set the maximum for the spinbox, to be consistent and not run in to issues should Qt decide to change the default.

Alternatively, remove the property here.

rkflx: In my patch I also came to the conclusion to increase this. I chose 80 (doubling the initial…
38 </property> 38​ </property>
39 <property name="orientation"> 39​ <property name="orientation">
40 <enum>Qt::Horizontal</enum> 40​ <enum>Qt::Horizontal</enum>
41 </property> 41​ </property>
42 </widget> 42​ </widget>
43 </item> 43​ </item>
44 <item> 44​ <item>
45 <widget class="QSpinBox" name="diameterSpinBox"> 45​ <widget class="QSpinBox" name="diameterSpinBox">
46 <property name="minimum"> 46​ <property name="minimum">
47 <number>2</number> 47​ <number>2</number>
48 </property> 48​ </property>
49​ <property name="maximum">
50​ <number>99</number>
51​ </property>
49 </widget> 52​ </widget>
50 </item> 53​ </item>
51 </layout> 54​ </layout>
52 <zorder>diameterSpinBox</zorder> 55​ <zorder>diameterSpinBox</zorder>
53 <zorder>label</zorder> 56​ <zorder>label</zorder>
54 <zorder>diameterSlider</zorder> 57​ <zorder>diameterSlider</zorder>
55 </widget> 58​ </widget>
56 <widget class="QWidget" name="notSetPage"> 59​ <widget class="QWidget" name="notSetPage">
Show All 14 Lines72 <item>
71 <property name="standardButtons"> 74​ <property name="standardButtons">
72 <set>QDialogButtonBox::Close|QDialogButtonBox::Ok</set> 75​ <set>QDialogButtonBox::Close|QDialogButtonBox::Ok</set>
73 </property> 76​ </property>
74 </widget> 77​ </widget>
75 </item> 78​ </item>
76 </layout> 79​ </layout>
77 </widget> 80​ </widget>
78 <resources/> 81​ <resources/>
79 <connections/> 82​ <connections>
83​ <connection>
84​ <sender>diameterSlider</sender>
85​ <signal>valueChanged(int)</signal>
rkflxUnsubmitted
Done

Does not work for keyboard use, only valueChanged will work.

rkflx: Does not work for keyboard use, only `valueChanged` will work.
muhlenpfordtAuthorUnsubmitted
Not Done

Thanks for the hint. I asked myself what's the difference and trusted in the old code...

muhlenpfordt: Thanks for the hint. I asked myself what's the difference and trusted in the old code...
86​ <receiver>diameterSpinBox</receiver>
87​ <slot>setValue(int)</slot>
88​ <hints>
89​ <hint type="sourcelabel">
90​ <x>96</x>
91​ <y>27</y>
92​ </hint>
93​ <hint type="destinationlabel">
94​ <x>183</x>
95​ <y>27</y>
96​ </hint>
97​ </hints>
98​ </connection>
99​ <connection>
100​ <sender>diameterSpinBox</sender>
101​ <signal>valueChanged(int)</signal>
102​ <receiver>diameterSlider</receiver>
103​ <slot>setValue(int)</slot>
104​ <hints>
105​ <hint type="sourcelabel">
106​ <x>183</x>
107​ <y>27</y>
108​ </hint>
109​ <hint type="destinationlabel">
110​ <x>96</x>
111​ <y>27</y>
112​ </hint>
113​ </hints>
114​ </connection>
115​ </connections>
80</ui> 116​</ui>