Changeset View
Changeset View
Standalone View
Standalone View
lib/redeyereduction/redeyereductionwidget.ui
| Show All 28 Lines | 21 | <item> | |||
|---|---|---|---|---|---|
| 29 | </widget> | 29 | </widget> | ||
| 30 | </item> | 30 | </item> | ||
| 31 | <item> | 31 | <item> | ||
| 32 | <widget class="QSlider" name="diameterSlider"> | 32 | <widget class="QSlider" name="diameterSlider"> | ||
| 33 | <property name="minimum"> | 33 | <property name="minimum"> | ||
| 34 | <number>2</number> | 34 | <number>2</number> | ||
| 35 | </property> | 35 | </property> | ||
| 36 | <property name="maximum"> | 36 | <property name="maximum"> | ||
| 37 | <number>40</number> | 37 | <number>99</number> | ||
rkflx: In my patch I also came to the conclusion to increase this. I chose 80 (doubling the initial… | |||||
| 38 | </property> | 38 | </property> | ||
| 39 | <property name="orientation"> | 39 | <property name="orientation"> | ||
| 40 | <enum>Qt::Horizontal</enum> | 40 | <enum>Qt::Horizontal</enum> | ||
| 41 | </property> | 41 | </property> | ||
| 42 | </widget> | 42 | </widget> | ||
| 43 | </item> | 43 | </item> | ||
| 44 | <item> | 44 | <item> | ||
| 45 | <widget class="QSpinBox" name="diameterSpinBox"> | 45 | <widget class="QSpinBox" name="diameterSpinBox"> | ||
| Show All 25 Lines | 69 | <item> | |||
| 71 | <property name="standardButtons"> | 71 | <property name="standardButtons"> | ||
| 72 | <set>QDialogButtonBox::Close|QDialogButtonBox::Ok</set> | 72 | <set>QDialogButtonBox::Close|QDialogButtonBox::Ok</set> | ||
| 73 | </property> | 73 | </property> | ||
| 74 | </widget> | 74 | </widget> | ||
| 75 | </item> | 75 | </item> | ||
| 76 | </layout> | 76 | </layout> | ||
| 77 | </widget> | 77 | </widget> | ||
| 78 | <resources/> | 78 | <resources/> | ||
| 79 | <connections/> | 79 | <connections> | ||
| 80 | <connection> | ||||
| 81 | <sender>diameterSlider</sender> | ||||
| 82 | <signal>sliderMoved(int)</signal> | ||||
rkflx: Does not work for keyboard use, only `valueChanged` will work. | |||||
Thanks for the hint. I asked myself what's the difference and trusted in the old code... muhlenpfordt: Thanks for the hint. I asked myself what's the difference and trusted in the old code... | |||||
| 83 | <receiver>diameterSpinBox</receiver> | ||||
| 84 | <slot>setValue(int)</slot> | ||||
| 85 | <hints> | ||||
| 86 | <hint type="sourcelabel"> | ||||
| 87 | <x>96</x> | ||||
| 88 | <y>27</y> | ||||
| 89 | </hint> | ||||
| 90 | <hint type="destinationlabel"> | ||||
| 91 | <x>183</x> | ||||
| 92 | <y>27</y> | ||||
| 93 | </hint> | ||||
| 94 | </hints> | ||||
| 95 | </connection> | ||||
| 96 | <connection> | ||||
| 97 | <sender>diameterSpinBox</sender> | ||||
| 98 | <signal>valueChanged(int)</signal> | ||||
| 99 | <receiver>diameterSlider</receiver> | ||||
| 100 | <slot>setValue(int)</slot> | ||||
| 101 | <hints> | ||||
| 102 | <hint type="sourcelabel"> | ||||
| 103 | <x>183</x> | ||||
| 104 | <y>27</y> | ||||
| 105 | </hint> | ||||
| 106 | <hint type="destinationlabel"> | ||||
| 107 | <x>96</x> | ||||
| 108 | <y>27</y> | ||||
| 109 | </hint> | ||||
| 110 | </hints> | ||||
| 111 | </connection> | ||||
| 112 | </connections> | ||||
| 80 | </ui> | 113 | </ui> | ||
In my patch I also came to the conclusion to increase this. I chose 80 (doubling the initial size), but 99 is probably also okay.
Still, here you are setting an explicit value, while for the spinbox the implicit default of 99 is used. I'd say you should also set the maximum for the spinbox, to be consistent and not run in to issues should Qt decide to change the default.
Alternatively, remove the property here.