Differential D12946 Diff 34379 kcms/workspaceoptions/package/contents/ui/main.qml

Changeset View

Standalone View

kcms/workspaceoptions/package/contents/ui/main.qml

Show All 33 Lines		32	Layouts.ColumnLayout {
34	spacing: units.largeSpacing	34		spacing: units.largeSpacing
35		35
36	// General Settings	36		// General Settings
37	Column {	37		Column {
38	spacing: units.smallSpacing	38		spacing: units.smallSpacing
39	leftPadding: units.smallSpacing	39		leftPadding: units.smallSpacing
40		40
41	Controls.Label {	41		Controls.Label {
42	id: generalSettings
43	text: i18n("General Settings")	42		text: i18n("General Settings")
44	}	43		}
45		44
46	Controls.CheckBox {	45		Controls.CheckBox {
47	id: showToolTips	46		id: showToolTips
48	text: i18n("Display informational tooltips on mouse hover")	47		text: i18n("Display informational tooltips on mouse hover")
49	checked: kcm.toolTip	48		checked: kcm.toolTip
50	onCheckedChanged: kcm.toolTip = checked	49		onCheckedChanged: kcm.toolTip = checked
51	}	50		}
52		51
53	Controls.CheckBox {	52		Controls.CheckBox {
54	id: showVisualFeedback	53		id: showVisualFeedback
55	text: i18n("Display visual feedback for status changes")	54		text: i18n("Display visual feedback for status changes")
56	checked: kcm.visualFeedback	55		checked: kcm.visualFeedback
57	onCheckedChanged: kcm.visualFeedback = checked	56		onCheckedChanged: kcm.visualFeedback = checked
58	}	57		}
59		58
60	Connections {	59		Connections {
61	target: kcm	60		target: kcm
62	onToolTipChanged: showToolTips.checked = kcm.toolTip	61		onToolTipChanged: showToolTips.checked = kcm.toolTip
63	onVisualFeedbackChanged: showVisualFeedback.checked = kcm.visualFeedback	62		onVisualFeedbackChanged: showVisualFeedback.checked = kcm.visualFeedback
64	}	63		}
65	}	64		}
		65
		66		// ClickBehaviour Settings
		67		Column {
		68		spacing: units.smallSpacing
		69		Controls.ExclusiveGroup { id: clickBehaviourGroup }
		70
		71		Controls.Label {
		72		text: i18n("Click Behaviour")
		73		}
		74
		75		Controls.RadioButton {
			romanggUnsubmitted Done Add: `checked: kcm.singleClick` romangg: Add: `checked: kcm.singleClick`
		76		id: singleClick
		77		text: i18n("Single-click to open files and folders")
		78		checked: kcm.singleClick
		79		exclusiveGroup: clickBehaviourGroup
		80		onCheckedChanged: kcm.singleClick = checked
		81		}
		82
			romanggUnsubmitted Done Add: `checked: !kcm.singleClick` romangg: Add: `checked: !kcm.singleClick`
		83		Controls.RadioButton {
		84		id: doubleClick
			davidedmundsonUnsubmitted Not Done I don't want to bike shed on this given the timing, but it is not just about files and folders. It affects almost all Qt grid views. The old wording was "select and activate icons". davidedmundson: I don't want to bike shed on this given the timing, but it is not just about files and folders.
			martUnsubmitted Not Done yes, text should still be double click to activate icons mart: yes, text should still be double click to activate icons
			romanggUnsubmitted Not Done It's already changed, right? romangg: It's already changed, right?
			martUnsubmitted Not Done i still see text: i18n("Single-click to open files and folders") mart: i still see text: i18n("Single-click to open files and folders")
			romanggUnsubmitted Not Done It was added to the double click setting below (such that the text reads now exactly like it was in the Mouse KCM). romangg: It was added to the double click setting below (such that the text reads now exactly like it…
			martUnsubmitted Not Done ok mart: ok
		85		text: i18n("Double-click to open files and folders (select icons on first click)")
		86		exclusiveGroup: clickBehaviourGroup
		87		}
		88
		89		Connections {
		90		target: kcm
			romanggUnsubmitted Done Just: `onSingleClickChanged: singleClick.checked = kcm.singleClick;` romangg: Just: `onSingleClickChanged: singleClick.checked = kcm.singleClick;`
			furkantokacAuthorUnsubmitted Done This is not okay. If singleclick is not set initially, doubleclick radio button should be enabled. This code doesn't to that. furkantokac: This is not okay. If singleclick is not set initially, doubleclick radio button should be…
			romanggUnsubmitted Done singleClick will be set initially through https://phabricator.kde.org/D12946#inline-66775 But you are right, it also needs `checked: !kcm.singleClick` for doubleClick to work. romangg: singleClick will be set initially through https://phabricator.kde.org/D12946#inline-66775 But…
		91		onSingleClickChanged: {
		92		singleClick.checked = kcm.singleClick
		93		doubleClick.checked = !singleClick.checked
		94		}
		95		}
		96		}
66	} // END Layouts.ColumnLayout	97		} // END Layouts.ColumnLayout
67	} // END Controls.ScrollView	98		} // END Controls.ScrollView
68	} // END Item	99		} // END Item