Single/Double Click Option at Workspace KCM
ClosedPublic

Authored by furkantokac on May 17 2018, 2:56 PM.

Details

Summary

This patch adds the single/double click option to
the Workspace KCM.

BUG: 393547
BUG: 377310

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
furkantokac requested review of this revision.May 17 2018, 2:56 PM
furkantokac created this revision.
romangg added inline comments.May 17 2018, 3:01 PM
kcms/workspaceoptions/workspaceoptions.cpp
51

Unrelated change. Revert pls.

132

Unrelated change. Revert pls.

189

Remove

198

Remove

romangg set the repository for this revision to R119 Plasma Desktop.
romangg added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMay 17 2018, 3:01 PM
romangg added inline comments.May 17 2018, 3:23 PM
kcms/workspaceoptions/package/contents/ui/main.qml
75

Add: checked: kcm.singleClick

90

Just: onSingleClickChanged: singleClick.checked = kcm.singleClick;

kcms/workspaceoptions/workspaceoptions.cpp
36–37

Add m_stateSingleClick(true)

davidedmundson added inline comments.
kcms/workspaceoptions/package/contents/ui/main.qml
84

I don't want to bike shed on this given the timing, but it is not just about files and folders.
It affects almost all Qt grid views.

The old wording was "select and activate icons".

furkantokac added inline comments.May 17 2018, 3:44 PM
kcms/workspaceoptions/package/contents/ui/main.qml
90

This is not okay. If singleclick is not set initially, doubleclick radio button should be enabled. This code doesn't to that.

romangg added inline comments.May 17 2018, 3:49 PM
kcms/workspaceoptions/package/contents/ui/main.qml
82

Add: checked: !kcm.singleClick

90

singleClick will be set initially through https://phabricator.kde.org/D12946#inline-66775

But you are right, it also needs checked: !kcm.singleClick for doubleClick to work.

Single/Double click implementation is done. Tested. Everything
is working fine.

QDBus is organized.

romangg edited the summary of this revision. (Show Details)May 17 2018, 4:46 PM
romangg set the repository for this revision to R119 Plasma Desktop.
mart added a subscriber: mart.May 17 2018, 4:53 PM
mart added inline comments.
kcms/workspaceoptions/package/contents/ui/main.qml
84

yes, text should still be double click to activate icons

Qml padding added. Some small fixes.

romangg accepted this revision.May 17 2018, 4:58 PM
romangg added inline comments.
kcms/workspaceoptions/package/contents/ui/main.qml
84

It's already changed, right?

This revision is now accepted and ready to land.May 17 2018, 4:58 PM
mart added inline comments.May 17 2018, 4:59 PM
kcms/workspaceoptions/package/contents/ui/main.qml
84

i still see text: i18n("Single-click to open files and folders")

furkantokac marked 10 inline comments as done.May 17 2018, 5:02 PM
romangg added inline comments.May 17 2018, 5:03 PM
kcms/workspaceoptions/package/contents/ui/main.qml
84

It was added to the double click setting below (such that the text reads now exactly like it was in the Mouse KCM).

mart added inline comments.May 17 2018, 5:04 PM
kcms/workspaceoptions/package/contents/ui/main.qml
84

ok

ngraham edited the summary of this revision. (Show Details)May 17 2018, 5:08 PM
mart accepted this revision.May 17 2018, 5:08 PM

QDBus is reorganized. Implementation is clear now.

This revision was automatically updated to reflect the committed changes.
rooty added a subscriber: rooty.Fri, Jul 20, 10:00 PM

hey guys, resident grammar nazi reporting :D
it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling)
a great idea otherwise

sorry :D

hey guys, resident grammar nazi reporting :D
it says Click Behaviour (british spelling), and the rest of the module uses Behavior (american spelling)
a great idea otherwise

sorry :D

This has since been corrected. :)