Differential D12893 Diff 34195 lookandfeel/contents/logout/timer.js

Changeset View

Standalone View

View Options

lookandfeel/contents/logout/timer.js

  • This file was copied from lookandfeel/contents/logout/LogoutButton.qml.
1/*************************************************************************** 1​/***************************************************************************
2 * Copyright (C) 2016 Marco Martin <mart@kde.org> * 2​ * Copyright (C) 2018 David Edmundson <davidedmundson@kde.org> *
3 * * 3​ * *
4 * This program is free software; you can redistribute it and/or modify * 4​ * This program is free software; you can redistribute it and/or modify *
5 * it under the terms of the GNU General Public License as published by * 5​ * it under the terms of the GNU General Public License as published by *
6 * the Free Software Foundation; either version 2 of the License, or * 6​ * the Free Software Foundation; either version 2 of the License, or *
7 * (at your option) any later version. * 7​ * (at your option) any later version. *
8 * * 8​ * *
9 * This program is distributed in the hope that it will be useful, * 9​ * This program is distributed in the hope that it will be useful, *
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of * 10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * 11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12 * GNU General Public License for more details. * 12​ * GNU General Public License for more details. *
13 * * 13​ * *
14 * You should have received a copy of the GNU General Public License * 14​ * You should have received a copy of the GNU General Public License *
15 * along with this program; if not, write to the * 15​ * along with this program; if not, write to the *
16 * Free Software Foundation, Inc., * 16​ * Free Software Foundation, Inc., *
17 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . * 17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
18 ***************************************************************************/ 18​ ***************************************************************************/
19 19​
20import QtQuick 2.2 20​.pragma library
21import QtQuick.Layouts 1.2 ​
22 21​
23import org.kde.plasma.core 2.0 as PlasmaCore 22​//written as a library to share knowledge of when a key was pressed
23​//between the multiple views, so pressing a key on one cancels all timers
24 24​
25import "../components" 25​var callbacks = [];
broulikUnsubmitted
Done

var callbacks = [];

broulik: `var callbacks = [];`
26 26​
27ActionButton { 27​function addCancelAutoTriggerCallback(callback) {
28 property var action 28​ callbacks.push(callback);
29 onClicked: action() ​
30 Layout.alignment: Qt.AlignTop ​
31 iconSize: units.iconSizes.huge ​
32 opacity: activeFocus || containsMouse ? 1 : 0.5 ​
33 font.underline: false ​
34 Behavior on opacity { ​
35 OpacityAnimator { ​
36 duration: units.longDuration ​
37 easing.type: Easing.InOutQuad ​
38 } 29​}
30​
31​function cancelAutoTrigger() {
32​ callbacks.forEach(function(c) {
broulikUnsubmitted
Not Done

I recall for .. in with JS Arrays being bad. I don't remember why, though.
Perhaps do

callbacks.forEach(function(c) { ... })
broulik: I recall `for .. in` with JS Arrays being bad. I don't remember why, though. Perhaps do ```…
33​ if (!c) {
34​ return;
broulikUnsubmitted
Done

Name it add as first reading the QML file I thought you were overwriting the callback every time

broulik: Name it `add` as first reading the QML file I thought you were overwriting the callback every…
39 } 35​ }
40 Keys.onPressed: countDownTimer.running = false 36​ c();
37​ });
41} 38​}
39​