Differential D12102 Diff 31923 kcms/translations/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/translations/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright (C) 2015 Marco Martin <mart@kde.org>
3​ * Copyright (C) 2018 Eike Hein <hein@kde.org>
4​ *
5​ * This library is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU Library General Public
7​ * License as published by the Free Software Foundation; either
8​ * version 2 of the License, or (at your option) any later version.
9​ *
10​ * This library is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13​ * Library General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU Library General Public License
16​ * along with this library; see the file COPYING.LIB. If not, write to
17​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ * Boston, MA 02110-1301, USA.
19​*/
20​
21​import QtQuick 2.1
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.3 as QtControls
24​import org.kde.kirigami 2.4 as Kirigami
25​import org.kde.plasma.core 2.1 as PlasmaCore
26​import org.kde.kcm 1.1
27​
28​SimpleKCM {
29​ id: root
30​
31​ ConfigModule.quickHelp: i18n("Language")
32​
33​ topPadding: 0
34​ leftPadding: 0
35​ rightPadding: 0
36​ bottomPadding: 0
37​
38​ Kirigami.OverlaySheet {
39​ id: addLanguagesSheet
40​
41​ parent: root.parent
42​
43​ topPadding: 0
44​ leftPadding: 0
45​ rightPadding: 0
46​ bottomPadding: 0
47​
48​ header: Kirigami.Heading { text: i18n("Add Languages") }
49​
50​ property var selectedLanguages: []
51​
52​ ListView {
53​ implicitWidth: Kirigami.Units.gridUnit * 18
54​ implicitHeight: Kirigami.Units.gridUnit * 15
55​
56​ model: PlasmaCore.SortFilterModel {
57​ id: availableLanguagesModel
58​
59​ sourceModel: addLanguagesSheet.sheetOpen ? kcm.translationsModel : null
60​
aspotashevUnsubmitted
Not Done

Please add context:

i18nc("@title:window", "Add Languages")
aspotashev: Please add context: ``` i18nc("@title:window", "Add Languages") ```
61​ filterRole: "IsSelected"
62​ filterCallback: function(source_row, value) { return !value; }
63​
64​ sortRole: "display"
65​ }
66​
67​ delegate: Kirigami.BasicListItem {
martUnsubmitted
Not Done

same consideration for Layout.* in delegates

mart: same consideration for Layout.* in delegates
martUnsubmitted
Not Done

sorry, counter what i told you before, setting an explicit width: in lists in overlaysheets actually breaks them, https://imgur.com/a/CPMhtYX
this line should be removed

mart: sorry, counter what i told you before, setting an explicit width: in lists in overlaysheets…
68​ Layout.fillWidth: true
69​
70​ property string languageCode: model.LanguageCode
71​
72​ reserveSpaceForIcon: false
73​
74​ label: model.display
75​
76​ checkable: true
77​ onCheckedChanged: {
78​ if (checked) {
79​ addLanguagesSheet.selectedLanguages.push(index);
80​ } else {
81​ addLanguagesSheet.selectedLanguages = addLanguagesSheet.selectedLanguages.filter(function(item) { return item !== index })
82​ }
83​ }
84​ }
85​ }
86​
87​ footer: QtControls.Button {
88​ width: parent.width
89​
90​ text: i18n("Add")
91​
92​ onClicked: {
93​ var langs = [];
94​ addLanguagesSheet.selectedLanguages.sort().forEach(function(index) {
95​ langs.push(availableLanguagesModel.get(index).LanguageCode);
96​ });
97​
98​ if (addLanguagesSheet.selectedLanguages.length) {
99​ if (kcm.translationsModel.selectedLanguages.length) {
100​ kcm.translationsModel.selectedLanguages = kcm.translationsModel.selectedLanguages.concat(langs);
101​ } else {
102​ kcm.translationsModel.selectedLanguages = langs;
103​ }
104​ }
105​
106​ addLanguagesSheet.sheetOpen = false;
107​ }
108​ }
109​ }
aspotashevUnsubmitted
Not Done

Please add context for translators:

i18nc("@action:button", "Add")
aspotashev: Please add context for translators: ``` i18nc("@action:button", "Add") ```
110​
111​ header: QtControls.Control {
112​ width: parent.width
113​ height: messagesLayout.implicitHeight + (messagesLayout.implicitHeight ? bottomPadding : 0)
114​
115​ bottomPadding: Kirigami.Units.smallSpacing
116​
117​ ColumnLayout {
118​ id: messagesLayout
119​
120​ width: parent.width
121​
122​ spacing: Kirigami.Units.largeSpacing
123​
124​ Kirigami.InlineMessage {
125​ Layout.fillWidth: true
126​ Layout.leftMargin: Kirigami.Units.smallSpacing
127​ Layout.rightMargin: Kirigami.Units.smallSpacing
128​
129​ type: kcm.everSaved ? Kirigami.MessageType.Positive : Kirigami.MessageType.Information
130​
131​ text: (kcm.everSaved ? i18n("Your changes will take effect the next time you log in.")
132​ : i18n("There are currently no preferred languages configured."))
133​
134​ visible: !languagesList.count || kcm.everSaved
135​ }
136​
137​ Kirigami.InlineMessage {
138​ Layout.fillWidth: true
139​ Layout.leftMargin: Kirigami.Units.smallSpacing
140​ Layout.rightMargin: Kirigami.Units.smallSpacing
141​
142​ type: Kirigami.MessageType.Error
143​
144​ text: i18ncp("%2 is the language code",
145​ "The translation files for the language with the code '%2' could not be found. The language will be removed from your configuration. If you want to add it back, please install the localization files for it and add the language again.",
146​ "The translation files for the languages with the codes '%2' could not be found. These languages will be removed from your configuration. If you want to add them back, please install the localization files for it and the languages again.",
aspotashevUnsubmitted
Not Done

Please add context:

i18nc("@info", "There are no languages available on this system.")
aspotashev: Please add context: ``` i18nc("@info", "There are no languages available on this system.") ```
147​ kcm.translationsModel.missingLanguages.length,
148​ kcm.translationsModel.missingLanguages.join("', '"))
149​
150​ visible: kcm.translationsModel.missingLanguages.length
151​ }
152​ }
153​ }
154​
155​ ListView {
156​ id: languagesList
157​
158​ Layout.fillWidth: true
aspotashevUnsubmitted
Not Done

Please add context "@info"

aspotashev: Please add context "@info"
159​
160​ model: PlasmaCore.SortFilterModel {
161​ sourceModel: kcm.translationsModel
162​
163​ filterRole: "IsSelected"
164​ filterCallback: function(source_row, value) { return value; }
165​
166​ sortRole: "SelectedPriority"
167​ }
168​
169​ delegate: Kirigami.SwipeListItem {
170​ id: listItem
171​
aspotashevUnsubmitted
Not Done

Please add context "@info":

i18ncp("@info %2 is the language code",
aspotashev: Please add context "@info": ``` i18ncp("@info %2 is the language code", ```
172​ Layout.fillWidth: true
173​ Layout.margins: 0
174​
175​ contentItem: RowLayout {
176​ width: implicitWidth
177​ height: Math.max(implicitHeight, Kirigami.Units.iconSizes.smallMedium)
178​
179​ anchors.verticalCenter: parent.verticalCenter
180​
181​ Kirigami.Icon {
182​ visible: model.IsMissing
183​
184​ Layout.alignment: Qt.AlignVCenter
185​
186​ width: Kirigami.Units.iconSizes.smallMedium
martUnsubmitted
Not Done

Layout.* attached properties are useless there, as items in a listview are not in a layout.
the correct thing to do here (as documented by qt) is even is not pretty:

width: languagesList.width

mart: Layout.* attached properties are useless there, as items in a listview are not in a layout. the…
187​ height: width
188​
189​ source: "error"
190​ color: Kirigami.Theme.negativeTextColor
191​ }
192​
193​ QtControls.Label {
194​ Layout.fillWidth: true
195​
196​ Layout.alignment: Qt.AlignVCenter
197​
198​ text: model.display
199​
200​ color: (model.IsMissing ? Kirigami.Theme.negativeTextColor
201​ : (listItem.checked || (listItem.pressed && !listItem.checked && !listItem.sectionDelegate)
202​ ? listItem.activeTextColor : listItem.textColor))
203​ }
204​ }
205​
206​ actions: [
207​ Kirigami.Action {
208​ enabled: !model.IsMissing && index > 0
209​ iconName: "arrow-up"
210​ onTriggered: kcm.translationsModel.selectedLanguages.splice(index - 1, 0, kcm.translationsModel.selectedLanguages.splice(index, 1)[0])
211​
212​ },
213​ Kirigami.Action {
214​ enabled: !model.IsMissing && index < (languagesList.count - 1)
215​ iconName: "arrow-down"
216​ onTriggered: kcm.translationsModel.selectedLanguages.splice(index + 1, 0, kcm.translationsModel.selectedLanguages.splice(index, 1)[0])
217​
218​ },
219​ Kirigami.Action {
220​ enabled: !model.IsMissing
221​ iconName: "list-remove"
222​ onTriggered: kcm.translationsModel.selectedLanguages = kcm.translationsModel.selectedLanguages.filter(function(item) { return item !== model.LanguageCode })
223​ }]
224​ }
225​ }
226​
227​ footer: QtControls.Control {
228​ width: parent.width
229​ height: footerLayout.implicitHeight + topPadding
230​
231​ topPadding: Kirigami.Units.smallSpacing
232​ leftPadding: Kirigami.Units.smallSpacing
233​ rightPadding: Kirigami.Units.smallSpacing
234​
235​ RowLayout {
236​ id: footerLayout
237​
238​ width: parent.width
239​
240​ QtControls.Button {
241​ Layout.alignment: Qt.AlignHCenter
242​
243​ text: i18n("Add languages...")
244​
245​ onClicked: addLanguagesSheet.sheetOpen = !addLanguagesSheet.sheetOpen
246​
247​ checkable: true
248​ checked: addLanguagesSheet.sheetOpen
249​ }
250​ }
251​ }
252​}
253​
aspotashevUnsubmitted
Not Done

Please add context "@action:button"

aspotashev: Please add context "@action:button"