Differential D12027 Diff 31615 src/filemetadataprovider.cpp

Changeset View

Standalone View

View Options

src/filemetadataprovider.cpp

Show First 20 Lines • Show All 388 Lines • ▼ Show 20 Line(s)385 static const TranslationItem translations[] = {
389 { "kfileitem#permissions", I18N_NOOP2_NOSTRIP("@label", "Permissions") }, 389​ { "kfileitem#permissions", I18N_NOOP2_NOSTRIP("@label", "Permissions") },
390 { "kfileitem#rating", I18N_NOOP2_NOSTRIP("@label", "Rating") }, 390​ { "kfileitem#rating", I18N_NOOP2_NOSTRIP("@label", "Rating") },
391 { "kfileitem#size", I18N_NOOP2_NOSTRIP("@label", "Size") }, 391​ { "kfileitem#size", I18N_NOOP2_NOSTRIP("@label", "Size") },
392 { "kfileitem#tags", I18N_NOOP2_NOSTRIP("@label", "Tags") }, 392​ { "kfileitem#tags", I18N_NOOP2_NOSTRIP("@label", "Tags") },
393 { "kfileitem#totalSize", I18N_NOOP2_NOSTRIP("@label", "Total Size") }, 393​ { "kfileitem#totalSize", I18N_NOOP2_NOSTRIP("@label", "Total Size") },
394 { "kfileitem#type", I18N_NOOP2_NOSTRIP("@label", "Type") }, 394​ { "kfileitem#type", I18N_NOOP2_NOSTRIP("@label", "Type") },
395 { "tags", I18N_NOOP2_NOSTRIP("@label", "Tags") }, 395​ { "tags", I18N_NOOP2_NOSTRIP("@label", "Tags") },
396 { "rating", I18N_NOOP2_NOSTRIP("@label", "Rating") }, 396​ { "rating", I18N_NOOP2_NOSTRIP("@label", "Rating") },
397 { "userComment", I18N_NOOP2_NOSTRIP("@label", "Comment") }, 397​ { "userComment", I18N_NOOP2_NOSTRIP("@label", "User Comment") },
michaelhAuthorUnsubmitted
Not Done

The label name is not good. Maybe a native speaker can come up with something better.

michaelh: The label name is not good. Maybe a native speaker can come up with something better.
brunsUnsubmitted
Not Done

Annotation, Note

bruns: Annotation, Note
michaelhAuthorUnsubmitted
Not Done

Another idea: Keep the userComment as "Comment" and use "Description" for comment

michaelh: Another idea: Keep the `userComment` as "Comment" and use "Description" for `comment`
elvisangelaccioUnsubmitted
Not Done

Note that this is a string change and will need approval from the i18n team before landing on 18.04

elvisangelaccio: Note that this is a string change and will need approval from the i18n team before landing on…
398 { "originUrl", I18N_NOOP2_NOSTRIP("@label", "Downloaded From") }, 398​ { "originUrl", I18N_NOOP2_NOSTRIP("@label", "Downloaded From") },
399 { 0, 0, 0} // Mandatory last entry 399​ { 0, 0, 0} // Mandatory last entry
400 }; 400​ };
401 401​
402 static QHash<QString, QString> hash; 402​ static QHash<QString, QString> hash;
403 if (hash.isEmpty()) { 403​ if (hash.isEmpty()) {
404 const TranslationItem* item = &translations[0]; 404​ const TranslationItem* item = &translations[0];
405 while (item->key != 0) { 405​ while (item->key != 0) {
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines