Differential D11021 Diff 28729 dataengines/mpris2/multiplexedservice.h

Changeset View

Standalone View

View Options

dataengines/mpris2/multiplexedservice.h

Context not available.
35public: 35​public:
36 MultiplexedService(Multiplexer *multiplexer, QObject *parent = nullptr); 36​ MultiplexedService(Multiplexer *multiplexer, QObject *parent = nullptr);
37 37​
38​ Q_INVOKABLE void changeVolume(double delta, bool showOSD) {
broulikUnsubmitted
Not Done

Shouldn't this be a job? So you use the startOperationCall stuff used elsewhere (for e.g. Play and so on)

broulik: Shouldn't this be a job? So you use the `startOperationCall` stuff used elsewhere (for e.g.
PitelAuthorUnsubmitted
Not Done

I guess it would look more consistent if it was a job but somehow I fail to see why any of this is job in the first place: all the actions are very simple so offloading work to other thread is not needed and it hides interface in ugly way... Do you have any insight why?

Pitel: I guess it would look more consistent if it was a job but somehow I fail to see why any of this…
broulikUnsubmitted
Not Done

That's how dataengines worked 10 years ago. I'm not a huge fan either but I'd like to keep it consistent(ly bad)

broulik: That's how dataengines worked 10 years ago. I'm not a huge fan either but I'd like to keep it…
39​ if (m_control) m_control->changeVolume(delta, showOSD);
40​ }
41​
38protected: 42​protected:
39 Plasma::ServiceJob *createJob(const QString &operation, 43​ Plasma::ServiceJob *createJob(const QString &operation,
40 QMap<QString,QVariant> &parameters) override; 44​ QMap<QString,QVariant> &parameters) override;
Context not available.