Differential D11021 Diff 28729 dataengines/mpris2/multiplexedservice.cpp

Changeset View

Standalone View

Context not available.
126	}	126		}
127	}	127		}
128	);	128		);
		129
		130		QAction *volumeupAction = m_actionCollection->addAction(QStringLiteral("mediavolumeup"));
		131		volumeupAction->setText(i18n("Media volume up"));
		132		KGlobalAccel::setGlobalShortcut(volumeupAction, QKeySequence());
		133		connect(volumeupAction, &QAction::triggered, this,
		134		[this] { changeVolume(0.05, true); }
		135		);
		136
			broulikUnsubmitted Not Done No need to abbreviate const qreal newVolume = ... broulik: No need to abbreviate ``` const qreal newVolume = ... ```
		137		QAction *volumedownAction = m_actionCollection->addAction(QStringLiteral("mediavolumedown"));
			broulikUnsubmitted Not Done Also enforce a limit here, qBound(0.0, vol, 1.0); broulik: Also enforce a limit here, ``` qBound(0.0, vol, 1.0); ```
		138		volumedownAction->setText(i18n("Media volume down"));
		139		KGlobalAccel::setGlobalShortcut(volumedownAction, QKeySequence());
		140		connect(volumedownAction, &QAction::triggered, this,
		141		[this] { changeVolume(-0.05, true); }
		142		);
129	}	143		}
130		144
Context not available.