Changeset View
Changeset View
Standalone View
Standalone View
src/lib/rule_p.h
Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Line(s) | |||||
241 | class WordDetect : public Rule | 241 | class WordDetect : public Rule | ||
242 | { | 242 | { | ||
243 | protected: | 243 | protected: | ||
244 | bool doLoad(QXmlStreamReader & reader) Q_DECL_OVERRIDE; | 244 | bool doLoad(QXmlStreamReader & reader) Q_DECL_OVERRIDE; | ||
245 | MatchResult doMatch(const QString & text, int offset, const QStringList &captures) Q_DECL_OVERRIDE; | 245 | MatchResult doMatch(const QString & text, int offset, const QStringList &captures) Q_DECL_OVERRIDE; | ||
246 | 246 | | |||
247 | private: | 247 | private: | ||
248 | QString m_word; | 248 | QString m_word; | ||
249 | Qt::CaseSensitivity m_caseSensitivity; | ||||
dhaumann: Could you initialize this to CaseInsensitive with in-class member initialization? | |||||
Yes, but it is in any case overwritten by doLoad(). StringDetect and others do not have this initialization either, should I also make the modification? jpoelen: Yes, but it is in any case overwritten by doLoad(). StringDetect and others do not have this… | |||||
249 | }; | 250 | }; | ||
250 | 251 | | |||
251 | } | 252 | } | ||
252 | 253 | | |||
253 | #endif // KSYNTAXHIGHLIGHTING_RULE_P_H | 254 | #endif // KSYNTAXHIGHLIGHTING_RULE_P_H |
Could you initialize this to CaseInsensitive with in-class member initialization?