Differential D10421 Diff 27173 app/generalconfigpage.ui

Changeset View

Standalone View

View Options

app/generalconfigpage.ui

1<?xml version="1.0" encoding="UTF-8"?> 1​<?xml version="1.0" encoding="UTF-8"?>
2<ui version="4.0"> 2​<ui version="4.0">
3 <class>GeneralConfigPage</class> 3​ <class>GeneralConfigPage</class>
4 <widget class="QWidget" name="GeneralConfigPage"> 4​ <widget class="QWidget" name="GeneralConfigPage">
5 <property name="geometry"> 5​ <property name="geometry">
6 <rect> 6​ <rect>
7 <x>0</x> 7​ <x>0</x>
8 <y>0</y> 8​ <y>0</y>
9 <width>470</width> 9​ <width>470</width>
10 <height>338</height> 10​ <height>338</height>
11 </rect> 11​ </rect>
12 </property> 12​ </property>
13 <layout class="QFormLayout" name="formLayout"> 13​ <layout class="QFormLayout" name="formLayout">
14​ <item row="0" column="0">
15​ <widget class="QLabel" name="label_2">
16​ <property name="text">
17​ <string>Videos:</string>
18​ </property>
19​ </widget>
20​ </item>
21​ <item row="0" column="1">
22​ <widget class="QCheckBox" name="kcfg_ListVideos">
23​ <property name="text">
24​ <string>Show videos</string>
25​ </property>
26​ </widget>
27​ </item>
28​ <item row="1" column="1">
29​ <spacer name="verticalSpacer">
30​ <property name="orientation">
31​ <enum>Qt::Vertical</enum>
32​ </property>
33​ <property name="sizeType">
34​ <enum>QSizePolicy::Fixed</enum>
35​ </property>
36​ <property name="sizeHint" stdset="0">
37​ <size>
38​ <width>20</width>
39​ <height>20</height>
40​ </size>
41​ </property>
42​ </spacer>
43​ </item>
14 <item row="2" column="0"> 44​ <item row="2" column="0">
15 <widget class="QLabel" name="label"> 45​ <widget class="QLabel" name="label">
16 <property name="text"> 46​ <property name="text">
17 <string>Background color:</string> 47​ <string>Background color:</string>
18 </property> 48​ </property>
19 </widget> 49​ </widget>
20 </item> 50​ </item>
21 <item row="2" column="1"> 51​ <item row="2" column="1">
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s)99 <property name="sizeHint" stdset="0">
71 <width>40</width> 101​ <width>40</width>
72 <height>20</height> 102​ <height>20</height>
73 </size> 103​ </size>
74 </property> 104​ </property>
75 </spacer> 105​ </spacer>
76 </item> 106​ </item>
77 </layout> 107​ </layout>
78 </item> 108​ </item>
79 <item row="0" column="0"> 109​ <item row="3" column="1">
80 <widget class="QLabel" name="label_2"> 110​ <spacer name="verticalSpacer_2">
81 <property name="text"> ​
82 <string>Videos:</string> ​
83 </property> ​
84 </widget> ​
85 </item> ​
86 <item row="0" column="1"> ​
87 <widget class="QCheckBox" name="kcfg_ListVideos"> ​
88 <property name="text"> ​
89 <string>Show videos</string> ​
90 </property> ​
91 </widget> ​
92 </item> ​
93 <item row="1" column="1"> ​
94 <spacer name="verticalSpacer"> ​
95 <property name="orientation"> 111​ <property name="orientation">
96 <enum>Qt::Vertical</enum> 112​ <enum>Qt::Vertical</enum>
97 </property> 113​ </property>
98 <property name="sizeType"> 114​ <property name="sizeType">
99 <enum>QSizePolicy::Fixed</enum> 115​ <enum>QSizePolicy::Fixed</enum>
100 </property> 116​ </property>
101 <property name="sizeHint" stdset="0"> 117​ <property name="sizeHint" stdset="0">
102 <size> 118​ <size>
103 <width>20</width> 119​ <width>20</width>
104 <height>20</height> 120​ <height>20</height>
105 </size> 121​ </size>
106 </property> 122​ </property>
107 </spacer> 123​ </spacer>
108 </item> 124​ </item>
125​ <item row="4" column="0">
126​ <widget class="QLabel" name="label_3">
127​ <property name="text">
128​ <string>Thumbnail actions:</string>
129​ </property>
130​ </widget>
131​ </item>
132​ <item row="4" column="1">
133​ <widget class="QRadioButton" name="allButtonsThumbnailActionsRadioButton">
134​ <property name="text">
135​ <string>All buttons</string>
136​ </property>
137​ </widget>
138​ </item>
139​ <item row="5" column="1">
140​ <widget class="QRadioButton" name="selectionOnlyThumbnailActionsRadioButton">
141​ <property name="text">
142​ <string>Show selection button onl&amp;y</string>
muhlenpfordtUnsubmitted
Not Done

Just noticed this preset accelerator (it's the only one on this and most other config pages).
Don't know if this can cause any trouble or breaks any guideline, but wanted to point out. ;)

muhlenpfordt: Just noticed this preset accelerator (it's the only one on this and most other config pages).
huoniAuthorUnsubmitted
Not Done

That's odd. I used Qt Designer to edit the General page, and didn't put that in on purpose.

I'm not sure what the best course of action is here. @rkflx thoughts?

huoni: That's odd. I used Qt Designer to edit the General page, and didn't put that in on purpose.
muhlenpfordtUnsubmitted
Not Done

I hated Designer for this automation more than once... ;)
Some time ago I found a solution somewhere, just add these lines to your KDE global config:

~/.config/kdeglobals
[Development]
AutoCheckAccelerators=false
muhlenpfordt: I hated Designer for this automation more than once... ;) Some time ago I found a solution…
huoniAuthorUnsubmitted
Not Done

Thanks, done!

huoni: Thanks, done!
rkflxUnsubmitted
Not Done

Late to the party, but yeah, I noticed this too when reviewing the patch but did not mention it in the end (my bad). Trying to undo this in Designer just put it somewhere else, making me question .ui files once more (just look at how noisy the patch is for this file…).

Removing this again moves the underline from onlY to shoW, which is not too bad.

A quick check shows that in some places this might be deliberate (done by Aurélien, at the start of words), while in some cases it might be the same mistake (e.g. in 4efdfcdae). I'll commit a fix tonight if nobody disagrees.

rkflx: Late to the party, but yeah, I noticed this too when reviewing the patch but did not mention it…
143​ </property>
144​ </widget>
145​ </item>
146​ <item row="6" column="1">
147​ <widget class="QRadioButton" name="noneThumbnailActionsRadioButton">
148​ <property name="text">
149​ <string>None</string>
150​ </property>
151​ </widget>
152​ </item>
109 </layout> 153​ </layout>
110 </widget> 154​ </widget>
111 <resources/> 155​ <resources/>
112 <connections/> 156​ <connections/>
113</ui> 157​</ui>