Changeset View
Changeset View
Standalone View
Standalone View
CMakeLists.txt
Show All 13 Lines | |||||
14 | find_package(Qt5WebKitWidgets CONFIG) | 14 | find_package(Qt5WebKitWidgets CONFIG) | ||
15 | set_package_properties(Qt5WebKitWidgets PROPERTIES | 15 | set_package_properties(Qt5WebKitWidgets PROPERTIES | ||
16 | URL "git://gitorious.org/qt/qtwebkit.git" | 16 | URL "git://gitorious.org/qt/qtwebkit.git" | ||
17 | DESCRIPTION "Qt Webkit module (web browsing engine)" | 17 | DESCRIPTION "Qt Webkit module (web browsing engine)" | ||
18 | TYPE OPTIONAL | 18 | TYPE OPTIONAL | ||
19 | PURPOSE "Used by the HTML-based GUI ksysguard library" | 19 | PURPOSE "Used by the HTML-based GUI ksysguard library" | ||
20 | ) | 20 | ) | ||
21 | 21 | | |||
22 | find_package(KF5 REQUIRED COMPONENTS CoreAddons Config I18n WindowSystem Completion Auth WidgetsAddons IconThemes ConfigWidgets Service) | 22 | find_package(KF5 REQUIRED COMPONENTS CoreAddons Config I18n WindowSystem Completion Auth WidgetsAddons IconThemes ConfigWidgets Service Plasma GlobalAccel KIO) | ||
rkflx: Is `Plasma` needed here? If so, I think this needs more discussion or should be made optional. | |||||
gregormi: No, it's not. I'll remove that. | |||||
23 | find_package(KF5 OPTIONAL_COMPONENTS Plasma) | 23 | find_package(KF5 OPTIONAL_COMPONENTS Plasma) | ||
24 | set_package_properties(KF5Plasma PROPERTIES | 24 | set_package_properties(KF5Plasma PROPERTIES | ||
25 | URL "https://cgit.kde.org/plasma-framework.git/" | 25 | URL "https://cgit.kde.org/plasma-framework.git/" | ||
26 | DESCRIPTION "The library of the plasma project" | 26 | DESCRIPTION "The library of the plasma project" | ||
27 | TYPE OPTIONAL | 27 | TYPE OPTIONAL | ||
28 | PURPOSE "Used by signalplotter to use Plasma themes" | 28 | PURPOSE "Used by signalplotter to use Plasma themes" | ||
29 | ) | 29 | ) | ||
30 | 30 | | |||
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines |
Is Plasma needed here? If so, I think this needs more discussion or should be made optional.
KSysGuard can also be used in other desktop environments and perhaps other apps consume this library too (KDevelop?), all of them might not want to bring in a huge dependency on Plasma.