Differential D9480 Diff 24738 KF5DBusAddonsMacros.cmake

Changeset View

Standalone View

View Options

KF5DBusAddonsMacros.cmake

  • This file was added.
1​set(_KDBUSADDONSDIR ${CMAKE_CURRENT_LIST_DIR})
2​
3​#
4​# kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH)
5​#
kropUnsubmitted
Done

kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the readability.

Please also document each parameter.

krop: kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the readability.
6​# This function generates a D-Bus service file and installs it
7​# into the specified destination.
kropUnsubmitted
Done

D-Bus

krop: D-Bus
8​#
9​# On Windows the path is not used because D-Bus service executables
10​# are always installed in the same directory as dbus-daemon.
kropUnsubmitted
Done

D-Bus

krop: D-Bus
11​#
12​# Parameters:
13​#
14​# EXECUTABLE - name of the executable
15​# NAME - service path in D-Bus
kropUnsubmitted
Done

${KDE_INSTALL_FULL_BINDIR}

krop: ${KDE_INSTALL_FULL_BINDIR}
16​# PATH - path to install the service file
17​#
18​# Example:
19​#
20​# kdbusaddons_generate_dbus_service_file(kded5 org.kde.kded5 ${KDE_INSTALL_FULL_BINDIR})
21​#
22​function(KDBUSADDONS_GENERATE_DBUS_SERVICE_FILE _executable _name _path)
23​ set(_file ${CMAKE_CURRENT_BINARY_DIR}/${_name}.service)
24​ set(_template ${_KDBUSADDONSDIR}/KF5dbus.service.in)
kropUnsubmitted
Done

You don't check whether _path is absolute. This shall return an error.

krop: You don't check whether _path is absolute. This shall return an error.
25​ set(NAME ${_name})
26​ if(WIN32)
27​ set(EXEC ${_executable})
28​ else()
29​ if(IS_ABSOLUTE _path)
30​ set(EXEC ${_path}/${_executable})
31​ else()
32​ message(FATAL_ERROR "Path ${_path} is not absolute")
33​ endif()
34​ endif()
35​ if(NOT EXISTS ${_file})
36​ message(STATUS "generating ${_file} from ${_template}")
37​ endif()
38​ configure_file(${_template} ${_file})
39​ install(FILES ${_file} DESTINATION ${KDE_INSTALL_DBUSSERVICEDIR})
40​endfunction()