Add cmake function 'kdbusaddons_generate_dbus_service_file'
ClosedPublic
Actions

Authored by habacker on Dec 22 2017, 8:37 PM.

Details

Reviewers

dfaure
kfunk

Commits

Summary

This function is added to hide platform-specific implementation details
when creating dbus service files.

Test Plan

Repository

R271 KDBusAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

habacker requested review of this revision.Dec 22 2017, 8:37 PM

krop added inline comments.

KF5DBusAddonsMacros.cmake
5	kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the readability. Please also document each parameter.
7	D-Bus
10	D-Bus
15	${KDE_INSTALL_FULL_BINDIR}
24	You don't check whether _path is absolute. This shall return an error.

dfaure requested changes to this revision.Jan 2 2018, 8:31 AM

dfaure added inline comments.

CMakeLists.txt
77	This file name should be prefixed with kf5 or something, to avoid possible clashes.

This revision now requires changes to proceed.Jan 2 2018, 8:31 AM

habacker marked 6 inline comments as done.Jan 2 2018, 9:56 AM

This revision is now accepted and ready to land.Jan 4 2018, 12:26 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (2 lines)
M		KF5DBusAddonsConfig.cmake.in (1 line)
A	M	KF5DBusAddonsMacros.cmake (40 lines)
A	M	KF5dbus.service.in (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24309	0d819bc		Dec 22 2017, 8:37 PM	★	★
Diff 2	24564	0d819bc	- fixed doc	Jan 2 2018, 9:55 AM	★	★
Diff 3	24738	f19cef5	R271:76aba6882ae3786d0f6e4ffd61b35ca5935062d8	Jan 4 2018, 8:11 PM	★	★