Changeset View
Changeset View
Standalone View
Standalone View
src/svnqt/targets.cpp
Show First 20 Lines • Show All 121 Lines • ▼ Show 20 Line(s) | 121 | { | |||
---|---|---|---|---|---|
122 | svn::Paths ret; | 122 | svn::Paths ret; | ||
123 | ret.reserve(paths.size()); | 123 | ret.reserve(paths.size()); | ||
124 | Q_FOREACH(const QString &path, paths) { | 124 | Q_FOREACH(const QString &path, paths) { | ||
125 | ret.push_back(svn::Path(path)); | 125 | ret.push_back(svn::Path(path)); | ||
126 | } | 126 | } | ||
127 | return svn::Targets(ret); | 127 | return svn::Targets(ret); | ||
128 | } | 128 | } | ||
129 | 129 | | |||
130 | svn::Targets Targets::fromUrlList(const QList<QUrl> &urls) | 130 | svn::Targets Targets::fromUrlList(const QList<QUrl> &urls, UrlConversion conversion) | ||
broulik: Can this instead be turned into an enum to avoid a boolean trap? `fromUrlList(foo, false)`… | |||||
131 | { | 131 | { | ||
132 | svn::Paths ret; | 132 | svn::Paths ret; | ||
133 | ret.reserve(urls.size()); | 133 | ret.reserve(urls.size()); | ||
134 | const bool preferLocalFile = conversion == UrlConversion::PreferLocalPath; | ||||
134 | Q_FOREACH(const QUrl &url, urls) { | 135 | Q_FOREACH(const QUrl &url, urls) { | ||
135 | ret.push_back(svn::Path(url.isLocalFile() ? url.toLocalFile() : url.url())); | 136 | ret.push_back(svn::Path((preferLocalFile && url.isLocalFile()) ? url.toLocalFile() : url.url())); | ||
136 | } | 137 | } | ||
137 | return svn::Targets(ret); | 138 | return svn::Targets(ret); | ||
138 | } | 139 | } | ||
139 | 140 | | |||
140 | } | 141 | } |
Can this instead be turned into an enum to avoid a boolean trap? fromUrlList(foo, false) isn't particularly descriptive at a glance