Changeset View
Changeset View
Standalone View
Standalone View
scene.h
Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Line(s) | 63 | public: | |||
---|---|---|---|---|---|
152 | /** | 152 | /** | ||
153 | * Whether the Scene is able to drive animations. | 153 | * Whether the Scene is able to drive animations. | ||
154 | * This is used as a hint to the effects system which effects can be supported. | 154 | * This is used as a hint to the effects system which effects can be supported. | ||
155 | * If the Scene performs software rendering it is supposed to return @c false, | 155 | * If the Scene performs software rendering it is supposed to return @c false, | ||
156 | * if rendering is hardware accelerated it should return @c true. | 156 | * if rendering is hardware accelerated it should return @c true. | ||
157 | **/ | 157 | **/ | ||
158 | virtual bool animationsSupported() const = 0; | 158 | virtual bool animationsSupported() const = 0; | ||
159 | 159 | | |||
160 | /** | ||||
161 | * The render buffer used by an XRender based compositor scene. | ||||
162 | * Default implementation returns XCB_RENDER_PICTURE_NONE | ||||
163 | **/ | ||||
164 | virtual xcb_render_picture_t xrenderBufferPicture() const; | ||||
davidedmundson: IMHO, as this class is generic, yet the return type is very specific, the name should be… | |||||
165 | | ||||
160 | Q_SIGNALS: | 166 | Q_SIGNALS: | ||
161 | void frameRendered(); | 167 | void frameRendered(); | ||
162 | 168 | | |||
163 | public Q_SLOTS: | 169 | public Q_SLOTS: | ||
164 | // a window has been destroyed | 170 | // a window has been destroyed | ||
165 | void windowDeleted(KWin::Deleted*); | 171 | void windowDeleted(KWin::Deleted*); | ||
166 | // shape/size of a window changed | 172 | // shape/size of a window changed | ||
167 | void windowGeometryShapeChanged(KWin::Toplevel* c); | 173 | void windowGeometryShapeChanged(KWin::Toplevel* c); | ||
▲ Show 20 Lines • Show All 467 Lines • Show Last 20 Lines |
IMHO, as this class is generic, yet the return type is very specific, the name should be reflect that and be
xrenderBufferPicture like effectsHandler has.