Differential D6197 Diff 15621 src/ioslaves/file/file.cpp

Changeset View

Standalone View

View Options

src/ioslaves/file/file.cpp

Context not available.
68#include <QMimeDatabase> 68​#include <QMimeDatabase>
69#include <QStandardPaths> 69​#include <QStandardPaths>
70#include <QDataStream> 70​#include <QDataStream>
71​#include <KAuth>
71 72​
72#if HAVE_VOLMGT 73​#if HAVE_VOLMGT
73#include <volmgt.h> 74​#include <volmgt.h>
Context not available.
154} 155​}
155 156​
156FileProtocol::FileProtocol(const QByteArray &pool, const QByteArray &app) 157​FileProtocol::FileProtocol(const QByteArray &pool, const QByteArray &app)
157 : SlaveBase(QByteArrayLiteral("file"), pool, app), mFile(nullptr) 158​ : SlaveBase(QByteArrayLiteral("file"), pool, app), mFile(nullptr), mPriviledgeOpStarted(false)
158{ 159​{
159} 160​}
160 161​
Context not available.
1376 } 1377​ }
1377} 1378​}
1378 1379​
1380​bool FileProtocol::execWithElevatedPrivilege(const QString &action, const QString &subAction, const QVariant &args, PrivilegeWarning warning)
1381​{
1382​#ifdef Q_OS_UNIX
elvisangelaccioUnsubmitted
Done

Can't this go in file_unix.cpp, without ifdefs?

elvisangelaccio: Can't this go in file_unix.cpp, without ifdefs?
aacidUnsubmitted
Done

Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how much it works) but adding an ifdef at this level seems the wrong thing to do.

aacid: Why is there an ifdef anyway? KAuth has at least a mac backend (no idea how much it works) but…
chinmoyrAuthorUnsubmitted
Done

This method will be used by FileProtocol::mkdir and FileProtocol::chmod which are not virtual method. So when called in windows this must return false for the time being. So IMO ifdef or something similar is necessary. What do you suggest?

chinmoyr: This method will be used by FileProtocol::mkdir and FileProtocol::chmod which are not virtual…
aacidUnsubmitted
Done

Well, just use KAuth, since there's no backend in windows it will return false, why do you need an ifdef?

aacid: Well, just use KAuth, since there's no backend in windows it will return false, why do you need…
1383​ QVariantMap argv;
1384​ argv.insert(QStringLiteral("arguments"), args);
1385​ argv.insert(QStringLiteral("subaction"), subAction);
1386​
1387​ KAuth::Action execAction(QStringLiteral("org.kde.kio.file.%1").arg(action));
elvisangelaccioUnsubmitted
Done

Prefer QLatin1String if you want to concatenate. Or you could use QStringLiteral("org.kde.kio.file.%1").arg(action).

elvisangelaccio: Prefer `QLatin1String` if you want to concatenate. Or you could use `QStringLiteral("org.kde.
1388​ execAction.setHelperId(QStringLiteral("org.kde.kio.file"));
1389​ execAction.setArguments(argv);
1390​
1391​ const bool showWarningForAction = (metaData(QStringLiteral("ShowInternalWarning")) == QStringLiteral("true"));
1392​
1393​ int kauthStatus = execAction.status();
1394​ if (kauthStatus == KAuth::Action::AuthRequiredStatus) {
1395​ mPriviledgeOpStarted = true;
1396​ }
1397​
1398​ // if we are unit testing let's pretend to execute the action.
1399​ if (metaData(QStringLiteral("UnitTesting")) == QStringLiteral("true")) {
1400​ QStringList testData;
1401​ testData += execAction.name();
1402​ testData += QString::number(execAction.isValid());
1403​ testData += execAction.helperId();
1404​ testData += QString::number(kauthStatus);
1405​
1406​ // fake authorization
1407​ // if "ShowInternalWarning" is also "true" then this fake authorization will make the
1408​ // situation appear as if 'execWithRoot' method has been called for the second time
elvisangelaccioUnsubmitted
Done

Missing i18n() here

elvisangelaccio: Missing i18n() here
1409​ // within the the threshold time which means a warning must be shown instead of an
elvisangelaccioUnsubmitted
Done

Use ButtonCode::Cancel rather than hardcoding 2

elvisangelaccio: Use `ButtonCode::Cancel` rather than hardcoding 2
1410​ // authentication dialog.
1411​ kauthStatus = KAuth::Action::AuthorizedStatus;
1412​
1413​ // fake operation ending
1414​ mPriviledgeOpStarted = false;
1415​
1416​ // fake warning
1417​ if (showWarningForAction)
1418​ testData += QStringLiteral("warningshown");
1419​
1420​ setMetaData(QStringLiteral("TestData"), testData.join(QStringLiteral(",")));
1421​ return true;
1422​ }
1423​
1424​ bool proceed = true;
1425​ if (kauthStatus == KAuth::Action::AuthorizedStatus
1426​ && !mPriviledgeOpStarted
1427​ && showWarningForAction) {
1428​ mPriviledgeOpStarted = true;
1429​ proceed = showWarning(warning);
1430​ }
1431​
1432​ if (proceed) {
1433​ auto reply = execAction.execute();
1434​ if (!reply->exec()) {
1435​ endPrivilegeOperation();
1436​ return false;
1437​ }
1438​ return true;
1439​ }
1440​ endPrivilegeOperation();
1441​#endif
1442​ return false;
1443​}
elvisangelaccioUnsubmitted
Done

I didn't get this messagebox after deleting something when I was already authenticated. What did I do wrong?

elvisangelaccio: I didn't get this messagebox after deleting something when I was already authenticated. What…
1444​
1445​void FileProtocol::endPrivilegeOperation()
1446​{
1447​ mPriviledgeOpStarted = false;
1448​}
1449​
1450​QString FileProtocol::warningMessage(PrivilegeWarning warnId) const
1451​{
1452​ QString message;
1453​ switch(warnId) {
1454​
1455​ case WARN_PRIVILEGE_DEL: {
1456​ message = i18n("You are attempting to delete a file from a write protected location. "
1457​ "Doing so may cause irreversible damage to your system. Do you want to proceed?");
1458​ break;
1459​ }
1460​ case WARN_PRIVILEGE_RMDIR: {
1461​ message = i18n("You are attempting to delete a directory from a write protected location. "
1462​ "Doing so may cause irreversible damage to your system. Do you want to proceed?");
1463​ break;
1464​ }
1465​
1466​ }
1467​
1468​ return message;
1469​}
1470​
1471​bool FileProtocol::showWarning(PrivilegeWarning warnId)
1472​{
1473​ int status = messageBox(WarningContinueCancel, warningMessage(warnId), QStringLiteral("Warning!"), QStringLiteral("Continue"), QStringLiteral("Cancel"));
1474​ return status != 2;
1475​}
1476​
1379// needed for JSON file embedding 1477​// needed for JSON file embedding
1380#include "file.moc" 1478​#include "file.moc"
Context not available.