Differential D6197 Diff 15385 src/ioslaves/file/file.h

Changeset View

Standalone View

View Options

src/ioslaves/file/file.h

Context not available.
100 100​
101 void fileSystemFreeSpace(const QUrl &url); // KF6 TODO: Turn into virtual method in SlaveBase 101​ void fileSystemFreeSpace(const QUrl &url); // KF6 TODO: Turn into virtual method in SlaveBase
102 102​
103​ enum PriviledgeWarning {
104​ WARN_PRIVILEDGE_DEL = 1,
105​ WARN_PRIVILEDGE_RMDIR
106​ };
107​ bool execWithRoot(const QString &action, const QString &subAction, const QVariant &args, PriviledgeWarning warning);
eliaspUnsubmitted
Done

I find execWithRoot() to be a bit misleading, as the goal shouldn't be to always elevate to root's privileges but to only what's required to execute the specific operation (e.g. browse /home/someotheruser doesn't need root's privileges but only someotheruser's privileges).

Always elevating to root is IMHO by far too permissive.

eliasp: I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always elevate to…
chinmoyrAuthorUnsubmitted
Done

I agree with you on the part that execWithRoot() is slightly misleading. So I changed it to execWithElevatedPrivilege(). And acquiring somotheruser's privileges still requires elevated privilege does it not?

chinmoyr: I agree with you on the part that execWithRoot() is slightly misleading. So I changed it to…
108​ void endPriviledgeOp();
elvisangelaccioUnsubmitted
Done

endProvidiledgeOperation() is more descriptive, no?

elvisangelaccio: `endProvidiledgeOperation()` is more descriptive, no?
109​ QString warningMessage(PriviledgeWarning warnId) const;
110​ bool showWarning(PriviledgeWarning warnId);
111​
103private: 112​private:
104 mutable QHash<KUserId, QString> mUsercache; 113​ mutable QHash<KUserId, QString> mUsercache;
105 mutable QHash<KGroupId, QString> mGroupcache; 114​ mutable QHash<KGroupId, QString> mGroupcache;
106 QFile *mFile; 115​ QFile *mFile;
116​ bool mPriviledgeOpStarted;
107}; 117​};
108 118​
109#endif 119​#endif
Context not available.