Differential D5908 Diff 14659 duchain/builders/declarationbuilder.h

Changeset View

Standalone View

View Options

duchain/builders/declarationbuilder.h

Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Line(s)116private:
140 FindVariableResults m_findVariable; 140​ FindVariableResults m_findVariable;
141 141​
142 /// The position of the current argument, will only be set inside function calls. 142​ /// The position of the current argument, will only be set inside function calls.
143 int m_functionCallParameterPos; 143​ int m_functionCallParameterPos;
144 /// Type of the current function, will only be set inside function calls. 144​ /// Type of the current function, will only be set inside function calls.
145 KDevelop::FunctionType::Ptr m_currentFunctionType; 145​ KDevelop::FunctionType::Ptr m_currentFunctionType;
146 /// The AstNode of the previous function declaration argument 146​ /// The AstNode of the previous function declaration argument
147 ParameterAst *m_functionDeclarationPreviousArgument; 147​ ParameterAst *m_functionDeclarationPreviousArgument;
148​ /// The AstNode of the previous function call argument
149​ FunctionCallParameterListElementAst *m_functionCallPreviousArgument;
mwolffUnsubmitted
Not Done

= nullptr;

it's otherwise potentially uninitialized

mwolff: ` = nullptr;` it's otherwise potentially uninitialized
pprkutAuthorUnsubmitted
Not Done

Should I add that to the one before as well? (m_functionDeclarationPreviousArgument)

pprkut: Should I add that to the one before as well? (m_functionDeclarationPreviousArgument)
mwolffUnsubmitted
Not Done

sure, or check whether it's inited in a ctor - if not, add it here (but preferrably do that in a separate patch)

mwolff: sure, or check whether it's inited in a ctor - if not, add it here (but preferrably do that in…
148 150​
149 unsigned int m_currentModifers; 151​ unsigned int m_currentModifers;
150 QString m_lastTopStatementComment; 152​ QString m_lastTopStatementComment;
151 153​
152 QHash<qint64, ClassDeclaration*> m_types; 154​ QHash<qint64, ClassDeclaration*> m_types;
153 QHash<qint64, FunctionDeclaration*> m_functions; 155​ QHash<qint64, FunctionDeclaration*> m_functions;
154 QHash<qint64, NamespaceDeclaration*> m_namespaces; 156​ QHash<qint64, NamespaceDeclaration*> m_namespaces;
155 QList<KDevelop::QualifiedIdentifier> m_upcomingClassVariables; 157​ QList<KDevelop::QualifiedIdentifier> m_upcomingClassVariables;
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines