Changeset View
Changeset View
Standalone View
Standalone View
shell_client.cpp
Show First 20 Lines • Show All 979 Lines • ▼ Show 20 Line(s) | |||||
980 | 980 | | |||
981 | bool ShellClient::isInternal() const | 981 | bool ShellClient::isInternal() const | ||
982 | { | 982 | { | ||
983 | return m_internal; | 983 | return m_internal; | ||
984 | } | 984 | } | ||
985 | 985 | | |||
986 | bool ShellClient::isLockScreen() const | 986 | bool ShellClient::isLockScreen() const | ||
987 | { | 987 | { | ||
988 | if (m_internalWindow) { | ||||
989 | return m_internalWindow->property("org_kde_ksld_emergency").toBool(); | ||||
broulik: Should this not fall-through rather than always returning if m_internalWindow? | |||||
if m_internalWindow is true the next condition can never be true. Due to that I use a direct return. graesslin: if m_internalWindow is true the next condition can never be true. Due to that I use a direct… | |||||
990 | } | ||||
988 | return surface()->client() == waylandServer()->screenLockerClientConnection(); | 991 | return surface()->client() == waylandServer()->screenLockerClientConnection(); | ||
989 | } | 992 | } | ||
990 | 993 | | |||
991 | bool ShellClient::isInputMethod() const | 994 | bool ShellClient::isInputMethod() const | ||
992 | { | 995 | { | ||
993 | if (m_internal && m_internalWindow) { | 996 | if (m_internal && m_internalWindow) { | ||
994 | return m_internalWindow->property("__kwin_input_method").toBool(); | 997 | return m_internalWindow->property("__kwin_input_method").toBool(); | ||
995 | } | 998 | } | ||
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines |
Should this not fall-through rather than always returning if m_internalWindow?