Support the emergency show property on ksld's lock screen window
ClosedPublic

Authored by graesslin on Mar 23 2017, 8:42 PM.

Details

Summary

The emergency show window should be considered as a lock screen window
and be shown while the screen is locked. This is the KWin part to D5157.

Diff Detail

Repository
R108 KWin
Branch
emergency-show
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Mar 23 2017, 8:42 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 23 2017, 8:42 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Apr 5 2017, 8:12 PM
broulik added inline comments.
shell_client.cpp
989

Should this not fall-through rather than always returning if m_internalWindow?

graesslin added inline comments.Apr 6 2017, 5:10 AM
shell_client.cpp
989

if m_internalWindow is true the next condition can never be true. Due to that I use a direct return.

broulik accepted this revision.Apr 6 2017, 8:11 AM
This revision is now accepted and ready to land.Apr 6 2017, 8:11 AM
This revision was automatically updated to reflect the committed changes.