Create Task
Maniphest T9718

disable hooks for mauikit repo
Closed, ResolvedPublic
Actions

Description

Hi, for mauikit I make use of the Luv icon theme as the default one for Android, and so it is added as a git submodule for convenience.
I'm opening this ticket to be able to push the commits of .gitmodules file.

camiloh created this task.Sep 20 2018, 4:57 PM
Restricted Application added a subscriber: sysadmin. · View Herald TranscriptSep 20 2018, 4:57 PM
nalvarez added a subscriber: nalvarez.Sep 21 2018, 7:52 PM

Why can't it be a plain old dependency searched by CMake? Surely it would be convenient for Android to make QtGraphicalEffects a submodule and build it together, but you live without it and search it in CMake instead. Why can't you do the same for Luv icons?

bcooksley removed camiloh as the assignee of this task.Sep 21 2018, 8:50 PM
bcooksley moved this task from External: Active to External: Awaiting Response on the Sysadmin board.
bcooksley added a subscriber: bcooksley.Sep 25 2018, 8:20 AM

Please respond to Nicolas' comment on this.

camiloh added a comment.Sep 26 2018, 5:03 AM

Hi, I'm sorry this took me so long to reply back. I've followed Nicolas advice and now instead of submodules it gets the needed repos from cmake.
thank you.

bcooksley closed this task as Resolved.Sep 26 2018, 7:57 AM
bcooksley claimed this task.

No worries! Thanks for confirming that resolved the issue for you.