review cmake-ignores
Closed, ResolvedPublic

Description

give all cmake-ignore rules a review.

they may be

  • no longer in cmake at all and can be dropped
  • packaged in 18.04 so we can easily pick them up
  • remain in place (in which case they should have a comment as to why they are not wanted)

(with dupes because workspaces are a mess)

root@do-neon-jenkins:/var/lib/jenkins/workspace# tail -n +1 -- *unstable*/packaging/debian/cmake-ignore
==> bionic_unstable_extras_kexi_src/packaging/debian/cmake-ignore <==
BUILD_TESTING
BUILD_COVERAGE
BUILD_EXAMPLES

KEXI_DEBUG_GUI
KEXI_SHOW_UNFINISHED
KEXI_SHOW_UNIMPLEMENTED
KEXI_AUTORISE_TABBED_TOOLBAR
KEXI_SCRIPTS_SUPPORT
KEXI_FORM_CURSOR_PROPERTY_SUPPORT
KEXI_SHOW_CONTEXT_HELP
KEXI_QUICK_PRINTING_SUPPORT
KEXI_AUTOFIELD_FORM_WIDGET_SUPPORT
KEXI_LIST_FORM_WIDGET_SUPPORT
KEXI_PIXMAP_COLLECTIONS_SUPPORT
KEXI_MACROS_SUPPORT
KEXI_TABLE_PRINT_SUPPORT
KEXI_PROJECT_TEMPLATES
KEXI_MIGRATEMANAGER_DEBUG

==> bionic_unstable_kde_drkonqi_src/packaging/debian/cmake-ignore <==
DrKonqiIntegrationTesting

==> bionic_unstable_neon-packaging_choqok_src/packaging/debian/cmake-ignore <==
TelepathyQt5

==> bionic_unstable_plasma_drkonqi_src/packaging/debian/cmake-ignore <==
DrKonqiIntegrationTesting

==> xenial_unstable_calligra_kexi_src/packaging/debian/cmake-ignore <==
BUILD_TESTING
BUILD_COVERAGE
BUILD_EXAMPLES

KEXI_DEBUG_GUI
KEXI_SHOW_UNFINISHED
KEXI_SHOW_UNIMPLEMENTED
KEXI_AUTORISE_TABBED_TOOLBAR
KEXI_SCRIPTS_SUPPORT
KEXI_FORM_CURSOR_PROPERTY_SUPPORT
KEXI_SHOW_CONTEXT_HELP
KEXI_QUICK_PRINTING_SUPPORT
KEXI_AUTOFIELD_FORM_WIDGET_SUPPORT
KEXI_LIST_FORM_WIDGET_SUPPORT
KEXI_PIXMAP_COLLECTIONS_SUPPORT
KEXI_MACROS_SUPPORT
KEXI_TABLE_PRINT_SUPPORT
KEXI_PROJECT_TEMPLATES
KEXI_MIGRATEMANAGER_DEBUG

==> xenial_unstable_extras_kexi_src/packaging/debian/cmake-ignore <==
BUILD_TESTING
BUILD_COVERAGE
BUILD_EXAMPLES

KEXI_DEBUG_GUI
KEXI_SHOW_UNFINISHED
KEXI_SHOW_UNIMPLEMENTED
KEXI_AUTORISE_TABBED_TOOLBAR
KEXI_SCRIPTS_SUPPORT
KEXI_FORM_CURSOR_PROPERTY_SUPPORT
KEXI_SHOW_CONTEXT_HELP
KEXI_QUICK_PRINTING_SUPPORT
KEXI_AUTOFIELD_FORM_WIDGET_SUPPORT
KEXI_LIST_FORM_WIDGET_SUPPORT
KEXI_PIXMAP_COLLECTIONS_SUPPORT
KEXI_MACROS_SUPPORT
KEXI_TABLE_PRINT_SUPPORT
KEXI_PROJECT_TEMPLATES
KEXI_MIGRATEMANAGER_DEBUG

==> xenial_unstable_kde_drkonqi_src/packaging/debian/cmake-ignore <==
DrKonqiIntegrationTesting

==> xenial_unstable_kde-extras_kexi_src/packaging/debian/cmake-ignore <==
BUILD_TESTING
BUILD_COVERAGE
BUILD_EXAMPLES

KEXI_DEBUG_GUI
KEXI_SHOW_UNFINISHED
KEXI_SHOW_UNIMPLEMENTED
KEXI_AUTORISE_TABBED_TOOLBAR
KEXI_SCRIPTS_SUPPORT
KEXI_FORM_CURSOR_PROPERTY_SUPPORT
KEXI_SHOW_CONTEXT_HELP
KEXI_QUICK_PRINTING_SUPPORT
KEXI_AUTOFIELD_FORM_WIDGET_SUPPORT
KEXI_LIST_FORM_WIDGET_SUPPORT
KEXI_PIXMAP_COLLECTIONS_SUPPORT
KEXI_MACROS_SUPPORT
KEXI_TABLE_PRINT_SUPPORT
KEXI_PROJECT_TEMPLATES
KEXI_MIGRATEMANAGER_DEBUG

==> xenial_unstable_neon-packaging_choqok_src/packaging/debian/cmake-ignore <==
TelepathyQt5

==> xenial_unstable_plasma_drkonqi_src/packaging/debian/cmake-ignore <==
DrKonqiIntegrationTesting
sitter created this task.Apr 27 2018, 10:45 AM
sitter triaged this task as Wishlist priority.
sitter moved this task from Backlog to Later on the KDE Neon : bionic board.
sitter moved this task from Later to Backlog on the KDE Neon : bionic board.Jun 21 2018, 10:37 AM
sitter updated the task description. (Show Details)Jun 27 2018, 9:01 AM
sitter added a comment.Oct 3 2018, 8:16 AM

kexi cmake-ignore needs comments on the BUILD_* vars, they are cmake options but kexi raises them as features that aren't enabled (BS, but oh well)

sitter moved this task from Backlog to Doing on the KDE Neon : bionic board.Nov 21 2018, 11:13 AM
sitter closed this task as Resolved.
sitter claimed this task.

kexi is legit, choqok was undone and fixed, drkonqi may be a bogus ignore, but I am not sure its worth bothering with what with our testing exposure being next to 0 anyway