Create Task
Maniphest T8038

Conversation view search
Closed, ResolvedPublic
Actions

Description

For search inside the conversation view we need to:

  • Create a list of matches from all mails in the conversation
  • Highlight those matches
  • Make it possible to jump through the matches
  • (perhaps filter mails that don't match at all)

The TextEdit that we use for simple mails does not seem to have any search API at all.

The webengine view has a findText call that highlights all matches, but no other control is provided.
Perhaps the way to go would be via javascript:
https://doc.qt.io/qt-5.10/qtwebengine-webenginewidgets-contentmanipulation-example.html

Highlighting stuff could be done via:

QString code = QStringLiteral("qt.jQuery('a').each( function () { qt.jQuery(this).css('background-color', 'yellow') } )");
view->page()->runJavaScript(code);

No idea about navigating them.

Overall it seems like a fairly involved exercise to the this going...

Related Objects
Search...

StatusAssignedTask
 ResolvedcmollekopfT1746 Fulltext search
 ResolvedcmollekopfT8038 Conversation view search
cmollekopf created this task.Feb 21 2018, 11:16 AM
cmollekopf triaged this task as Normal priority.
cmollekopf added a comment.Feb 23 2018, 5:13 PM

Javascript isolation to implement the search functionality could be achieved by running the scripts in WebEngineScript.ApplicationWorld.

cmollekopf added a comment.Feb 23 2018, 5:15 PM

We now simply highlight all matches.

In the webengineview we use findText, and in the plaintextview we use a syntaxhighlighter.

The search string simply follows the one from the maillist so far and there is no way of navigating through all matches.

cmollekopf moved this task from Backlog to Done on the Kube (0.6) board.Feb 23 2018, 5:15 PM
cmollekopf closed this task as Resolved.Jul 5 2018, 3:03 PM
cmollekopf claimed this task.