Create Task
Maniphest T7206

Fix threading issue with AddToArchive
Closed, ResolvedPublic
Actions

Description

When compressing something from dolphin:

QObject: Cannot create children for a parent that is in a different thread.
(Parent is Kerfuffle::CreateJob(0x55830bd27050), parent's thread is QThread(0x55830b7e3960),         current thread is Kerfuffle::Job::Private(0x55830bcd0b20)

Details

Differential Revisions
D8718: CreateJob: create destination entry in the main thread
Commits
R36:d5fdd114f01c: Fix threading issue
elvisangelaccio added a comment.Nov 7 2017, 10:34 PM

Problem is in CreateJob::doWork() at

m_addJob = archive()->addFiles(m_entries, new Archive::Entry(this), m_options);

since this (=CreateJob) has been created in the main thread, while doWork() is executed in another thread (with libarchive and libzip plugins).

elvisangelaccio claimed this task.Nov 8 2017, 11:47 AM
elvisangelaccio moved this task from Backlog to Under review on the Ark board.