Create Task
Maniphest T5406

clarify "other reviews"
Closed, ResolvedPublic
Actions

Description

I just found a very useful (and very hidden) feature: Incoming review queries can be grouped. But I have a list of "other reviews" in there, and I don't know why they are in that group and what "other reviews" is even supposed to be. All three review requests are accepted by me and should be part of the "ready to land" section as far as I can see...

https://phabricator.kde.org/differential/query/24y1NhhYOdwv/

mwolff created this task.Feb 18 2017, 11:38 PM
bcooksley added a subscriber: bcooksley.Feb 21 2017, 5:53 AM

From a quick look at it, this appears to be for reviews for which one or more people have objected to a previous revision, but someone else has accepted the current revision. It's thus been reviewed, but it is unclear whether it is good to be landed.

bcooksley added a comment.Feb 26 2017, 9:38 PM

This is now being tracked at upstream https://secure.phabricator.com/T12323

bcooksley closed this task as Resolved.Feb 27 2017, 11:30 PM
bcooksley claimed this task.

This has now been fixed by upstream. The fix will be included in the next update to stable we do.
https://secure.phabricator.com/T12323