Create Task
Maniphest T3876

Embed Dr. Mingw in the Windows MinGW build
Closed, ResolvedPublic
Actions

Description

See if we can use ExcHndl in Dr. Mingw to add a crash handler and generate a stack trace. The goal is to help Windows users report crashes with clearer information without having to install Dr. Mingw manually.

It seems that we will need to include Microsoft's dbghelp.dll and symsrv.dll (both from the Debugging Tools for Windows. We should check the licensing terms of that and list what may have to be added to documentations. A specific version might be needed.

Also see if it is possible to show a helpful UI on crash, instead of just saving to a file. May need a separate process for that since the crashing process is already unstable. Probably just a simple win32 program with a dialog. We could use Qt for the UI but probably nothing too fancy.

Details

Differential Revisions
D2907: Add Dr. Mingw as crash handler on Windows

Related Objects

alvinhochun renamed this task from Embed Dr. Mingw in the Windows MinGW build for stack traces on crashes to Embed Dr. Mingw in the Windows MinGW build.Sep 26 2016, 6:05 PM
alvinhochun updated the task description. (Show Details)
alvinhochun added a comment.Sep 27 2016, 6:01 PM

The author of Dr. Mingw had talked about including dbghelp.dll and symsrv.dll with the binary package here: https://github.com/jrfonseca/drmingw/issues/17

Looks like there isn't much we can worry about. I guess the best we can do is to include the redistributable licence text with the binary release?

alvinhochun added a comment.Oct 4 2016, 2:31 AM

With the patch committed, Krita should now dump stack traces to %LocalAppData%\kritacrash.log. This should probably be noted in the docs, particularly the FAQ where Dr. Mingw is mentioned.

Depending on how the debugging symbols will be released in future versions, the relevant parts might also need to be updated.

alvinhochun removed alvinhochun as the assignee of this task.Oct 27 2016, 7:31 AM
alvinhochun closed this task as Resolved.Oct 28 2016, 1:31 PM
alvinhochun claimed this task.
alvinhochun reopened this task as Open.Oct 30 2016, 4:33 PM
alvinhochun removed alvinhochun as the assignee of this task.

Still need to update the FAQ to reflect this...

alvinhochun added a comment.Nov 12 2016, 2:09 PM

A page regarding this information is created here: https://docs.krita.org/Dr._Mingw_debugger

alvinhochun added a project: Krita: Manual.Nov 12 2016, 2:09 PM
alvinhochun moved this task from Backlog to Needs Writing on the Krita: Manual board.
alvinhochun closed this task as Resolved.Dec 31 2016, 7:08 AM
alvinhochun claimed this task.